Skip to content

Propose some references about ci/cd solutions compatibles with gitea #7996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 29, 2019
Merged

Propose some references about ci/cd solutions compatibles with gitea #7996

merged 13 commits into from
Aug 29, 2019

Conversation

camlafit
Copy link
Contributor

  • No note about theirs integrations level, it's only a starting point.

@camlafit
Propose some references about ci/cd solutions compatibles with gitea
35bc096 
* No note about theirs integration level, only a starting point.
lafriks
lafriks requested changes Aug 27, 2019
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 27, 2019
camlafit and others added 2 commits August 27, 2019 11:25
@camlafit @lafriks
Update docs/content/doc/advanced/ci-cd.en-us.md
39eb8c5 
Improve text

Co-Authored-By: Lauris BH <[email protected]>
@camlafit @lafriks
Improve link to CI solutions
d9fd112 
Update docs/content/doc/advanced/ci-cd.en-us.md

Co-Authored-By: Lauris BH <[email protected]>
@camlafit
Copy link
Contributor Author

Hello

I've updated texts as suggested

Thanks

@codecov-io
Copy link

codecov-io commented Aug 27, 2019 •
edited
Loading

Codecov Report

Merging #7996 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7996      +/-   ##
==========================================
- Coverage   41.59%   41.58%   -0.01%     
==========================================
  Files         480      480              
  Lines       64144    64144              
==========================================
- Hits        26678    26676       -2     
- Misses      34006    34008       +2     
  Partials     3460     3460
Impacted Files Coverage Δ
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c4148...bdbe955. Read the comment docs.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Aug 27, 2019
@techknowlogick
Copy link
Member

Thanks for the contribution, I think most of these are already on https://docs.gitea.io/en-us/third-party-tools/, perhaps you could merge your changes into that file?

@camlafit @jolheiser
Update docs/content/doc/advanced/ci-cd.en-us.md
bdcfe19 
Typo in name :/

Co-Authored-By: John Olheiser <[email protected]>
@camlafit
Copy link
Contributor Author

@techknowlogick but when i do my search to have an idea about compatible CI ecosystem, I haven't found this page. Act as an hidden page, is not intuitive to check this page.

As CI tools looks as a source management continuity, I think could be better to propose a specific page.

@lafriks
Copy link
Member

lafriks commented Aug 27, 2019

I agree about moving CI/CD to separate page. This PR should replace CI section with link to new page from 3rd party tools page

@techknowlogick
Copy link
Member

Please disregard my last comment. @lafriks has suggested a better way.

@camlafit
Copy link
Contributor Author

Please disregard my last comment. @lafriks has suggested a better way.

I've update third party page with a replacement link. Hope it's correct.

jolheiser
jolheiser requested changes Aug 28, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree having a CI/CD page would be good for clarity. Just a few nits, thanks for the PR!

@camlafit
Copy link
Contributor Author

Suggestions applied thanks

@camlafit
Copy link
Contributor Author

Patches applied

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 29, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2019
@techknowlogick techknowlogick merged commit 18896d8 into go-gitea:master Aug 29, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks requested changes

@appleboy appleboy appleboy requested changes

@techknowlogick techknowlogick techknowlogick approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@camlafit @codecov-io @techknowlogick @lafriks @appleboy @jolheiser @lunny @GiteaBot