Skip to content

Unit tests for models/wiki #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2017
Merged

Conversation

ethantkoenig
Copy link
Member

Unfornuately, many of the functions in models/wiki.go rely on git and the file-system, so they can't be tested until we find a good approach for testing functions with git/file-system dependencies.

@strk
Copy link
Member

strk commented Jan 28, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 28, 2017
@andreynering
Copy link
Contributor

LGTM

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2017
@andreynering andreynering merged commit 31c717f into go-gitea:master Jan 28, 2017
@ethantkoenig ethantkoenig deleted the tests/wiki branch January 30, 2017 01:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants