Skip to content

fix drone build bug #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2019
Merged

Conversation

Cherrg
Copy link
Contributor

@Cherrg Cherrg commented Jun 13, 2019

current master branch breaks drone build because of a misspelling bug in
./routers/user/oauth.go:172 -> added with #6418

  • fix some less format warning
  • fix makefile

Signed-off-by: Michael Gnehr [email protected]

caused by misspell-check
+ remove make css warning -> missing empty lines

Signed-off-by: Michael Gnehr <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 13, 2019
@techknowlogick techknowlogick added type/bug topic/code-linting and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 13, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 13, 2019
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jun 13, 2019
Signed-off-by: Michael Gnehr <[email protected]>
@Cherrg
Copy link
Contributor Author

Cherrg commented Jun 13, 2019

hopefully it will build now
-> fixed makefile

@Cherrg Cherrg force-pushed the build_misspell_bug branch from 5399dba to 962a8bc Compare June 13, 2019 03:42
Signed-off-by: Michael Gnehr <[email protected]>
@Cherrg Cherrg force-pushed the build_misspell_bug branch from 962a8bc to 5222bcb Compare June 13, 2019 03:46
Signed-off-by: Michael Gnehr <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #7192 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7192      +/-   ##
==========================================
+ Coverage   41.52%   41.53%   +<.01%     
==========================================
  Files         449      449              
  Lines       61306    61306              
==========================================
+ Hits        25460    25462       +2     
+ Misses      32492    32490       -2     
  Partials     3354     3354
Impacted Files Coverage Δ
routers/user/oauth.go 41.04% <0%> (ø) ⬆️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f0182c...81b3d40. Read the comment docs.

@techknowlogick techknowlogick merged commit 2f39fc7 into go-gitea:master Jun 13, 2019
@Cherrg Cherrg deleted the build_misspell_bug branch June 13, 2019 04:24
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants