-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
UI: Fix overflow issues in repo #7190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fix layout overflow in repo file list. - Fix invisible status icon in file view and commit list. In file view, the icon was moved to the left because I could not figure out a proper fix because of HTML tables. - Added title attribute to commit messages. - Fixed two CSS linter warnings in existing CSS. - Fixed CI variable check in 'make css'. Fixes: go-gitea#7180
If anyone has a better idea on how to get the icon (and text-overflow) to work correctly on the right side of the file view header, shoot. Couldn't figure it out while testing with Firefox. I imagine it being easier to fix in Chrome as it seems to handle text overflow in tables quite differently than Firefox (which for some reason falls back to display no text at all in some cases). |
Thinking about maybe truncating the commit line to 50 or 72 chars before rendering and making sure the UI has enough space for that so we don't have to rely on wonky CSS-based truncation. |
Looks like Github cuts off at 70 characters(plus an ellipse) which seems reasonable for this. |
Codecov Report
@@ Coverage Diff @@
## master #7190 +/- ##
==========================================
- Coverage 41.53% 41.52% -0.01%
==========================================
Files 449 449
Lines 61306 61306
==========================================
- Hits 25462 25456 -6
- Misses 32490 32497 +7
+ Partials 3354 3353 -1
Continue to review full report at Codecov.
|
Yeah, will look into doing that, so please consider this PR a WIP. |
Imho that character limit can be done in other PR |
Feel free to merge this now. I will follow up with another PR that does the truncation and moves the icon in the file table to the right again later. |
- Fix layout overflow in repo file list. - Fix invisible status icon in file view and commit list. In file view, the icon was moved to the left because I could not figure out a proper fix because of HTML tables. - Added title attribute to commit messages. - Fixed two CSS linter warnings in existing CSS. - Fixed CI variable check in 'make css'. Fixes: go-gitea#7180
Fixes: #7180
Screenshots: