Skip to content

Adjusts minimum Go version in documentation to 1.11 #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

saitho
Copy link
Contributor

@saitho saitho commented Jun 6, 2019

Gitea uses the "-mod" option in go run which is introduced with Go v1.11.
Documentation states 1.9 as minimum version. Therefore we should update documentations. :)

Gitea uses the "-mod" option in go run which is introduced with Go v1.11

Signed-off-by: Mario Lubenka <[email protected]>
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimum go version supported is 1.10, as we need to ensure that go build works for that version. This will change when Gitea v1.9.0 is released when we can move to go 1.11

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #7148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7148   +/-   ##
=======================================
  Coverage   41.58%   41.58%           
=======================================
  Files         446      446           
  Lines       60873    60873           
=======================================
  Hits        25317    25317           
  Misses      32271    32271           
  Partials     3285     3285
Impacted Files Coverage Δ
modules/log/log.go 69.36% <0%> (-2.71%) ⬇️
modules/avatar/avatar.go 54% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd55f6f...6176069. Read the comment docs.

@saitho
Copy link
Contributor Author

saitho commented Jun 6, 2019

I would be fine merging this with the release of 1.9.
Just checked out master and noticed that I need Go v1.11 in order to compile it.

@techknowlogick
Copy link
Member

I would be fine merging this with the release of 1.9.

As we will be releasing Gitea 1.9 soon, there is a freeze and as such a change such as this will have to wait until after 1.9 is released.

Just checked out master and noticed that I need Go v1.11 in order to compile it.

You shouldn't, and in fact each commit to master is checked that it can compile with Go v1.10

@saitho
Copy link
Contributor Author

saitho commented Jun 6, 2019

Hm. Building with Go 1.10 fails saying that the option -mod is not available for "go run", pointing to this file: https://github.com/go-gitea/gitea/blob/master/modules/options/options.go on line 7.
Might also be a misconfiguration on my end, as I installed Go on a freshly installed Ubuntu. ^^

@techknowlogick
Copy link
Member

For reference here is the command you can run: https://github.com/go-gitea/gitea/blob/master/.drone.yml#L65 the makefile may not support 1.10, but running with just go build does

@techknowlogick techknowlogick added this to the 1.10.0 milestone Jun 6, 2019
@tonivj5
Copy link
Contributor

tonivj5 commented Jun 7, 2019

Hm. Building with Go 1.10 fails saying that the option -mod is not available for "go run", pointing to this file: /modules/options/options.go@master on line 7.
Might also be a misconfiguration on my end, as I installed Go on a freshly installed Ubuntu. ^^

Fail happens when you build with bindata using makefile (TAGS="bindata" make generate). I think this should be remarked

@sapk
Copy link
Member

sapk commented Jun 7, 2019

It is only the makefile that break compat for The build command. We can maybe introduce build-compat command. We check compat with 1.10 on the CI. The command make release or make release-linux (or the os of your choice) should still work.

@sapk
Copy link
Member

sapk commented Jun 7, 2019

Looking at #7149 the command make generate is maybe also broken by the need of Go1.11

@lunny
Copy link
Member

lunny commented Jun 8, 2019

Maybe because I introduced the vfsgen and add -mod=vendor on go generate.

@lunny
Copy link
Member

lunny commented Jun 8, 2019

I think we can fix this by remove -mod=vendor in go generate on release v1.9 and added it back on v1.10 :)

@techknowlogick
Copy link
Member

This has been accomplished in another PR. Thanks for PR :)

@lunny lunny removed this from the 1.10.0 milestone Jul 8, 2019
@saitho saitho deleted the docs/adjust-min-golang-version branch December 18, 2019 18:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants