-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Adjusts minimum Go version in documentation to 1.11 #7148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gitea uses the "-mod" option in go run which is introduced with Go v1.11 Signed-off-by: Mario Lubenka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimum go version supported is 1.10, as we need to ensure that go build
works for that version. This will change when Gitea v1.9.0 is released when we can move to go 1.11
Codecov Report
@@ Coverage Diff @@
## master #7148 +/- ##
=======================================
Coverage 41.58% 41.58%
=======================================
Files 446 446
Lines 60873 60873
=======================================
Hits 25317 25317
Misses 32271 32271
Partials 3285 3285
Continue to review full report at Codecov.
|
I would be fine merging this with the release of 1.9. |
As we will be releasing Gitea 1.9 soon, there is a freeze and as such a change such as this will have to wait until after 1.9 is released.
You shouldn't, and in fact each commit to master is checked that it can compile with Go v1.10 |
Hm. Building with Go 1.10 fails saying that the option -mod is not available for "go run", pointing to this file: https://github.com/go-gitea/gitea/blob/master/modules/options/options.go on line 7. |
For reference here is the command you can run: https://github.com/go-gitea/gitea/blob/master/.drone.yml#L65 the makefile may not support 1.10, but running with just go build does |
Fail happens when you build with bindata using makefile ( |
It is only the makefile that break compat for The build command. We can maybe introduce build-compat command. We check compat with 1.10 on the CI. The command |
Looking at #7149 the command |
Maybe because I introduced the vfsgen and add |
I think we can fix this by remove |
This has been accomplished in another PR. Thanks for PR :) |
Gitea uses the "-mod" option in go run which is introduced with Go v1.11.
Documentation states 1.9 as minimum version. Therefore we should update documentations. :)