Skip to content

backport 1.6.4 to HEAD #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2019
Merged

backport 1.6.4 to HEAD #5742

merged 3 commits into from
Jan 16, 2019

Conversation

techknowlogick
Copy link
Member

As title

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Jan 16, 2019
@codecov-io
Copy link

codecov-io commented Jan 16, 2019 •
edited
Loading

Codecov Report

Merging #5742 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5742      +/-   ##
==========================================
+ Coverage   37.75%   37.77%   +0.01%     
==========================================
  Files         325      325              
  Lines       47681    47681              
==========================================
+ Hits        18003    18010       +7     
+ Misses      27083    27080       -3     
+ Partials     2595     2591       -4
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_indexer.go 48.3% <0%> (+3.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d384c9...18884f3. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 16, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2019
@jonasfranz
Copy link
Member

#5669 is a security issue not a Bugfix.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2019
@lafriks
Copy link
Member

lafriks commented Jan 16, 2019

@jonasfranz it's too late to fix this in this PR

@techknowlogick techknowlogick merged commit 19e651c into go-gitea:master Jan 16, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-12 branch January 16, 2019 15:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @codecov-io @jonasfranz @lafriks @lunny @bkcsoft