Fix the Let's Encrypt handler by listening on a valid address #5525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle errors in the HTTP server go routine, return a fatal error when something goes wrong. Thanks to @gbl08ma for finding the actual bug Here is an example of the error handling: 2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind: permission denied Closes go-gitea#5280
3 tasks
techknowlogick
approved these changes
Dec 11, 2018
bkcsoft
added
the
lgtm/need 1
|
@techknowlogick because listenAddr already contains a port number and we need to use a different one for this handler. It's the whole point of the bug that's being fixed, see my reply on the issue. |
|
Ah yes, thanks for clarification 😄 |
sapk
approved these changes
Dec 11, 2018
bkcsoft
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #5525 +/- ##
==========================================
+ Coverage 37.58% 37.59% +0.01%
==========================================
Files 318 318
Lines 46928 46928
==========================================
+ Hits 17638 17643 +5
+ Misses 26778 26774 -4
+ Partials 2512 2511 -1
Continue to review full report at Codecov.
|
|
Thanks for the PR @gregkare. Now that this has been merged, would you be able to send a backport PR to the release/v1.6 branch? |
gregkare
added a commit
to 67P/gitea
that referenced
this pull request
Dec 11, 2018
* Fix the Let's Encrypt handler by listening on a valid address Also handle errors in the HTTP server go routine, return a fatal error when something goes wrong. Thanks to @gbl08ma for finding the actual bug Here is an example of the error handling: 2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind: permission denied Closes go-gitea#5280 * Fix a typo
techknowlogick
pushed a commit
that referenced
this pull request
Dec 11, 2018
* Fix the Let's Encrypt handler by listening on a valid address Also handle errors in the HTTP server go routine, return a fatal error when something goes wrong. Thanks to @gbl08ma for finding the actual bug Here is an example of the error handling: 2018/12/11 14:23:07 [....io/gitea/cmd/web.go:87 func1()] [E] Failed to start the Let's Encrypt handler on port 30: listen tcp 0.0.0.0:30: bind: permission denied Closes #5280 * Fix a typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also handle errors in the HTTP server go routine, return a fatal error when something goes wrong.
Thanks to @gbl08ma for finding the actual bug
Here is an example of the error handling:
Closes #5280, replaces #5524 (pushed to the wrong organization)
Edit: This is my first Go pull request so I am open to suggestions about the error handling