-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[WIP] Fix data race caused by blevesearch/bleve #5217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
98881cc
to
e424f4a
Compare
So many files changed and it's difficult to review. |
@lunny This PR has not been finished yet. |
I based the PR on the master of But how will it look like if I make changes on a vendored package? AFAIK, the Makefile would reject any local change to the vendor directory. |
Fixing it upstream is a bit of cumbersome, it would be great if I can fix it in Gitea alone like #5224 |
@typeless update the vendor could be a standalone PR. Is this data race made by https://github.com/blevesearch/bleve, https://github.com/ethantkoenig/rupture or gitea's code? |
@lunny See https://github.com/ethantkoenig/rupture/blob/master/flushing_batch.go#L60-L67 The method Meanwhile, the following I can not prove if the map entries (other than the value of the map itself) of Because the goroutine is spawned inside the |
Would you like to continue this PR or maybe we could close this one. |
Got it. Won't have time to work on this in the near future. |
For #5189