Skip to content

Fix #rrggbbaa color to rgba for better browser compatibility #4990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2018

Conversation

SagePtr
Copy link
Contributor

@SagePtr SagePtr commented Sep 28, 2018

Fixes #4988

Color format #rrggbbaa is not widely supported by browsers yet: https://caniuse.com/#search=rgba
Less fade function is better here as it generates rgba(r, g, b, a) format output which has much better browser support. Also Less <3.8.1 handles #rrggbbaa format wrong as pointed in #4988 issue.

@codecov-io
Copy link

codecov-io commented Sep 28, 2018

Codecov Report

Merging #4990 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4990      +/-   ##
=========================================
- Coverage    37.4%   37.4%   -0.01%     
=========================================
  Files         306     306              
  Lines       45373   45373              
=========================================
- Hits        16974   16972       -2     
- Misses      25945   25948       +3     
+ Partials     2454    2453       -1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 61.76% <0%> (-1.18%) ⬇️
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81702e6...590ad2e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 28, 2018
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Sep 28, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 28, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 28, 2018
@techknowlogick
Copy link
Member

Maintainer note: This doesn't have a milestone applied to it. I'd like it to be in 1.6, but we should wait for #4971 to get merged first before merging this as the other PR already had to resolve conflicts arising from other CSS changes. I don't want to have the other contributor to have to resolve the same conflicts again.

That being said, I am only one of many maintainers and so if someone has a different opinion that is fine too.

@lafriks lafriks added this to the 1.6.0 milestone Sep 28, 2018
@lafriks
Copy link
Member

lafriks commented Sep 29, 2018

Please rebase and resolve conflicts

@SagePtr
Copy link
Contributor Author

SagePtr commented Sep 29, 2018

Done it and regenerated stylesheet

@lafriks lafriks merged commit fc0001c into go-gitea:master Sep 29, 2018
@SagePtr SagePtr deleted the issue4988 branch September 29, 2018 11:02
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong LESS conversion
7 participants