-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Fix #rrggbbaa color to rgba for better browser compatibility #4990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4990 +/- ##
=========================================
- Coverage 37.4% 37.4% -0.01%
=========================================
Files 306 306
Lines 45373 45373
=========================================
- Hits 16974 16972 -2
- Misses 25945 25948 +3
+ Partials 2454 2453 -1
Continue to review full report at Codecov.
|
Maintainer note: This doesn't have a milestone applied to it. I'd like it to be in 1.6, but we should wait for #4971 to get merged first before merging this as the other PR already had to resolve conflicts arising from other CSS changes. I don't want to have the other contributor to have to resolve the same conflicts again. That being said, I am only one of many maintainers and so if someone has a different opinion that is fine too. |
Please rebase and resolve conflicts |
Done it and regenerated stylesheet |
Fixes #4988
Color format #rrggbbaa is not widely supported by browsers yet: https://caniuse.com/#search=rgba
Less fade function is better here as it generates rgba(r, g, b, a) format output which has much better browser support. Also Less <3.8.1 handles #rrggbbaa format wrong as pointed in #4988 issue.