Show review comment box only on a pull request page #4636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4636 +/- ##
=======================================
Coverage 20.63% 20.63%
=======================================
Files 166 166
Lines 32261 32261
=======================================
Hits 6657 6657
Misses 24626 24626
Partials 978 978Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
|
LGTM |
bkcsoft
added
lgtm/need 1
appleboy
approved these changes
Aug 7, 2018
bkcsoft
added
lgtm/done
lafriks
reviewed
Aug 7, 2018
templates/repo/diff/box.tmpl
Outdated
| @@ -8,7 +8,7 @@ | |||
| <div class="ui right"> | |||
| <a class="ui tiny basic toggle button" href="?style={{if .IsSplitStyle}}unified{{else}}split{{end}}">{{ if .IsSplitStyle }}{{.i18n.Tr "repo.diff.show_unified_view"}}{{else}}{{.i18n.Tr "repo.diff.show_split_view"}}{{end}}</a> | |||
| <a class="ui tiny basic toggle button" data-target="#diff-files">{{.i18n.Tr "repo.diff.show_diff_stats"}}</a> | |||
| {{if $.SignedUserID}} | |||
| {{if (.PageIsPullFiles) and $.SignedUserID}} | |||
There was a problem hiding this comment.
Shouldn't this be: and .PageIsPullFiles $.SignedUserID?
lafriks
approved these changes
Aug 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4625 as per @lunny 's #4625 (comment)