Skip to content

Allow user to set an external tracker url and forward to it #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Allow user to set an external tracker url and forward to it #41

merged 1 commit into from
Nov 4, 2016

Conversation

DblK
Copy link
Member

@DblK DblK commented Nov 3, 2016

This is the same as my PR #3646 I suggest on Gogs

@tboerger tboerger added this to the 1.0.0 milestone Nov 3, 2016
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
Copy link
Member

@strk strk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strk
Copy link
Member

strk commented Nov 3, 2016

BTW, a rebase to master would be nice (to reduce the change to a single commit)

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

@strk you need to write the LGTM as a regular comment, LGTM is not aware of approval comments yet.

Beside a required rebase it LGTM.

@strk
Copy link
Member

strk commented Nov 3, 2016

Does it need to be just a single world: LGTM or would things like "I would not say LGTM" be taken as an approval ? :)

@strk
Copy link
Member

strk commented Nov 3, 2016

Looks like it was interpreted as approval (ok, in this case)

@tboerger tboerger added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Nov 3, 2016
@codecov-io
Copy link

codecov-io commented Nov 4, 2016

Current coverage is 2.18% (diff: 100%)

Merging #41 into master will not change coverage

@@            master       #41   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update 4a5faec...8dc49dc

@tboerger tboerger merged commit fc55182 into go-gitea:master Nov 4, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants