Skip to content

don't reset team/repo count when updating team via API #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2018
Merged

don't reset team/repo count when updating team via API #3831

merged 4 commits into from
Apr 29, 2018

Conversation

thehowl
Copy link
Contributor

@thehowl thehowl commented Apr 22, 2018

fixes #3600. Previously, we recreated the Team from scratch. We now modify the existing team that we get from ctx.Org.Team.

@codecov-io
Copy link

codecov-io commented Apr 22, 2018

Codecov Report

Merging #3831 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3831      +/-   ##
==========================================
+ Coverage      23%   23.01%   +0.01%     
==========================================
  Files         126      126              
  Lines       24892    24892              
==========================================
+ Hits         5726     5729       +3     
+ Misses      18289    18287       -2     
+ Partials      877      876       -1
Impacted Files Coverage Δ
modules/process/manager.go 73.91% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc36567...b45369e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 22, 2018
@lafriks lafriks added this to the 1.5.0 milestone Apr 22, 2018
@lunny
Copy link
Member

lunny commented Apr 23, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2018
@lunny lunny merged commit e3028d1 into go-gitea:master Apr 29, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: Edit team breaks member and repository count
5 participants