Modify pagination in page of commits #3766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted navigation to the page "first" and the page "last" of the pages of commits. I discovered this has already been implemented in one of the templates. Signed-off-by: Tan Pheng Heong <[email protected]>
lunny
added
type/refactoring
Codecov Report
@@ Coverage Diff @@
## master #3766 +/- ##
=========================================
- Coverage 22.91% 22.9% -0.02%
=========================================
Files 124 124
Lines 24750 24750
=========================================
- Hits 5672 5669 -3
- Misses 18216 18218 +2
- Partials 862 863 +1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
jonasfranz
approved these changes
Apr 6, 2018
bkcsoft
added
lgtm/need 1
Bwko
approved these changes
Apr 6, 2018
bkcsoft
added
lgtm/done
appleboy
approved these changes
Apr 7, 2018
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re. issue #3716
I wanted to check if the changes that I have made are viewed as acceptable, because I observed that the code that I indirectly refer to (namely, paginate.tmpl )was last modified in the year 2017 A.D. (and the format of the hyperlinks may have changed since then, if you know what I am referring to.)
Here's a screenshot: (I draw your attention to the navigation at the bottom of the image)
