Skip to content

Fix MySQL and PostgreSQL column drop SQL #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2018
Merged

Fix MySQL and PostgreSQL column drop SQL #3649

merged 1 commit into from
Mar 9, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Mar 8, 2018

Fixes #3646

Broken code after testing it 🤦‍♂️

@lafriks lafriks added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP backport/v1.4 labels Mar 8, 2018
@lafriks lafriks added this to the 1.5.0 milestone Mar 8, 2018
@codecov-io
Copy link

Codecov Report

Merging #3649 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3649   +/-   ##
======================================
  Coverage    35.9%   35.9%           
======================================
  Files         286     286           
  Lines       41312   41312           
======================================
  Hits        14832   14832           
  Misses      24298   24298           
  Partials     2182    2182
Impacted Files Coverage Δ
models/migrations/migrations.go 2.58% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a83581...421c3d7. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2018
@lunny
Copy link
Member

lunny commented Mar 9, 2018

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 9, 2018
@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 9, 2018
@appleboy appleboy merged commit de8a091 into go-gitea:master Mar 9, 2018
@lafriks lafriks deleted the fix/nonmssql_drop_cols branch March 9, 2018 06:40
lafriks added a commit to lafriks-fork/gitea that referenced this pull request Mar 9, 2018
@lafriks
Fix MySQL and PostgreSQL column drop SQL (go-gitea#3649)
56974e5
@lafriks lafriks mentioned this pull request Mar 9, 2018
Merged
@lafriks lafriks added the backport/done All backports for this PR have been created label Mar 9, 2018
lunny pushed a commit that referenced this pull request Mar 10, 2018
@lafriks @lunny
Fix MySQL and PostgreSQL column drop SQL (#3649) (#3651)
5d0c987
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Latest gitea container causes PostgreSQL database error, no longer launches
5 participants
@lafriks @codecov-io @lunny @appleboy @tboerger