Fix incorrect 'Erase Wiki Data' string identifier. #3613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
approved these changes
Mar 2, 2018
tboerger
added
the
lgtm/need 1
lafriks
approved these changes
Mar 2, 2018
tboerger
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #3613 +/- ##
==========================================
+ Coverage 36.14% 36.15% +<.01%
==========================================
Files 285 285
Lines 40910 40910
==========================================
+ Hits 14787 14789 +2
+ Misses 23951 23948 -3
- Partials 2172 2173 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal dialog to confirm erasure of repository wiki data doesn't use a valid string identifier. I couldn't find any unit tests depending on this, so hopefully it's an easy pull.