Skip to content

Refactor view issue & comment list styles #35061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025
Merged

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jul 13, 2025

The copy-paste code caused various problems, this PR fixes all and make the code maintainable.

There might be some small UI regressions that I didn't found, while these should be easy to fix, indeed we have clearer code

Fix #35060

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 13, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Jul 13, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Jul 13, 2025

image image image image image image

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 13, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jul 13, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 13, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 13, 2025
@wxiaoguang wxiaoguang merged commit 7cc47da into go-gitea:main Jul 13, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-ui branch July 13, 2025 14:52
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 14, 2025
* giteaofficial/main:
  Refactor view issue & comment list styles (go-gitea#35061)
  Fix user's sign email check (go-gitea#35045)
  [skip ci] Updated translations via Crowdin
  Fix incorrect comment diff hunk parsing, fix github asset ID nil panic (go-gitea#35046)
  Add Notifications section in User Settings (go-gitea#35008)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR "compare" button wrong size
5 participants