Skip to content

Optimize flex layout of release attachment area #34885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2025
Merged

Optimize flex layout of release attachment area #34885

merged 3 commits into from
Jun 27, 2025

Conversation

kerwin612
Copy link
Member

before:
b975dce7-d5b1-43e0-b6f4-94557758e30e

after:
682ce03c-9d2c-4b5d-9ba0-fb759fd98088

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 27, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Jun 27, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 27, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 27, 2025 •
edited
Loading

The new UI's first column is too narrow on mobile (although old UI is not ideal either, it shows enough information)

image

image

@kerwin612 kerwin612 force-pushed the fix/release-attachment-flex-optimize branch from 5482b07 to 4d9d707 Compare June 27, 2025 15:04
wxiaoguang
wxiaoguang approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better than before. Thank you.

(Some edge cases could only be resolved by rewriting to a grid layout, while I think it would be more complicated and doesn't need to be in this PR's scope)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 27, 2025
@lunny lunny added topic/ui Change the appearance of the Gitea UI backport/v1.24 This PR should be backported to Gitea 1.24 reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 27, 2025
@lunny lunny enabled auto-merge (squash) June 27, 2025 16:39
@lunny lunny merged commit 69fc561 into go-gitea:main Jun 27, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Jun 27, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 27, 2025
@kerwin612 @GiteaBot
Optimize flex layout of release attachment area (go-gitea#34885)
8bc6297 
before:

![b975dce7-d5b1-43e0-b6f4-94557758e30e](https://github.com/user-attachments/assets/c33f3fd0-ce1a-457c-97fe-942b86cf09c1)

after:

![682ce03c-9d2c-4b5d-9ba0-fb759fd98088](https://github.com/user-attachments/assets/55304b19-a3c3-4a91-b07a-0c9868dbe3eb)
@GiteaBot GiteaBot mentioned this pull request Jun 27, 2025
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 27, 2025
@wxiaoguang wxiaoguang deleted the fix/release-attachment-flex-optimize branch June 28, 2025 01:10
wxiaoguang pushed a commit that referenced this pull request Jun 28, 2025
@GiteaBot @kerwin612
Optimize flex layout of release attachment area (#34885) (#34886)
90e9e79 
Backport #34885 by kerwin612

Co-authored-by: Kerwin Bryant <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 30, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
52f07e0 
* giteaofficial/main:
  Add a `login`/`login-name`/`username` disambiguation to affected endpoint parameters and response/request models (go-gitea#34901)
  Improve tags list page (go-gitea#34898)
  [skip ci] Updated translations via Crowdin
  docs: fix typo in pull request merge warning message text (go-gitea#34899)
  Refactor container package (go-gitea#34877)
  [skip ci] Updated translations via Crowdin
  Fix project column edit (go-gitea#34890)
  Upgrade htmx to 2.0.6 (go-gitea#34887)
  Optimize flex layout of release attachment area (go-gitea#34885)
  Improve `labels-list` rendering (go-gitea#34846)
  enforce explanation for necessary nolints and fix bugs (go-gitea#34883)
  Fix a regression when refactoring fork list (go-gitea#34879)
  enforce nolint scope (go-gitea#34851)
@wxiaoguang wxiaoguang mentioned this pull request Jul 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kerwin612 @wxiaoguang @delvh @lunny @GiteaBot