Skip to content

Fix discord webhook 400 status code when description limit is exceeded #34084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 4, 2025
Merged

Fix discord webhook 400 status code when description limit is exceeded #34084

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8876d34
limit discord description size
Mopcho Mar 31, 2025
46df7e5
Truncate at 2000-th character for simplicity
Mopcho Apr 4, 2025
a97413c
Merge branch 'go-gitea:main' into set-limit-to-discord-wh-description
Mopcho Apr 4, 2025
0916ac6
Improve comment
Mopcho Apr 4, 2025
57a0fd7
Update services/webhook/discord.go
wxiaoguang Apr 4, 2025
3352661
Merge branch 'main' into set-limit-to-discord-wh-description
GiteaBot Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion services/webhook/discord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ var (
redColor = color("ff3232")
)

// https://discord.com/developers/docs/resources/message#embed-object-embed-limits
// Discord has some limits in place for the embeds.
// According to some tests, there is no consistent limit for different character sets.
// For example: 4096 ASCII letters are allowed, but only 2490 emoji characters are allowed.
// To keep it simple, we currently truncate at 2000.
const discordDescriptionCharactersLimit = 2000

type discordConvertor struct {
Username string
AvatarURL string
Expand Down Expand Up @@ -313,7 +320,7 @@ func (d discordConvertor) createPayload(s *api.User, title, text, url string, co
Embeds: []DiscordEmbed{
{
Title: title,
Description: text,
Description: util.TruncateRunes(text, discordDescriptionCharactersLimit),
URL: url,
Color: color,
Author: DiscordEmbedAuthor{
Expand Down