Skip to content

Remove extended glob pattern from branch protection UI #33125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

TheFox0x7
Copy link
Contributor

Underlying go library has no support for it

Fixes: #33121


I never touched frontend tests so pointers how to write them are welcome.

This can be either fix or workaround, depending if this is something gitea should support in the future or not. The golang side is unlikely to get updates though.

Underlying go library has no support for it
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2025
@lunny lunny requested a review from Zettat123 January 6, 2025 23:20
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 6, 2025
@lafriks lafriks merged commit 4a18c72 into go-gitea:main Jan 6, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 6, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 7, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Remove extended glob pattern from branch protection UI (go-gitea#33125)
  fix empty repo updated time (go-gitea#33120)
  Refactor package (routes and error handling, npm peer dependency) (go-gitea#33111)
  Refactor legacy JS (go-gitea#33115)
  Fix repo empty guide (go-gitea#33114)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

branch protection status check pattern
4 participants