Rename gogs.go to main.go with all references #33
Conversation
|
LGTM |
| outPath=./output | ||
|
|
||
| rm -rf $outPath | ||
| mkdir $outPath | ||
|
|
||
| go build ../gogs.go | ||
| go build ../main.go |
There was a problem hiding this comment.
Shouldn't this have -o gitea.go?
There was a problem hiding this comment.
AFAIK it should take the directory name, but you can prove that I'm wrong :)
There was a problem hiding this comment.
Even though the file is named main.go this is still incorrect, since @tboerger is correct 🙂
| outPath=./output | ||
|
|
||
| rm -rf $outPath | ||
| mkdir $outPath | ||
|
|
||
| go build ../gogs.go | ||
| go build ../main.go | ||
| PLATFORM=`uname | cut -d _ -f 1` | ||
| if [ $PLATFORM = "MINGW32" ] || [ $PLATFORM = "MINGW64" ] || [ $PLATFORM = "CYGWIN" ]; then | ||
| GOGS_EXE=gogs.exe |
There was a problem hiding this comment.
I think we should review what this does, too.
| outPlattform=freebsd | ||
| outArch=amd64 | ||
| outPath=./output_$outPlattform_$outArch | ||
|
|
||
| rm -rf $outPath | ||
| mkdir $outPath | ||
|
|
||
| CGO_ENABLED=0 GOOS=$outPlattform GOARCH=$outArch go build ../gogs.go | ||
| CGO_ENABLED=0 GOOS=$outPlattform GOARCH=$outArch go build ../main.go |
| outPlattform=linux | ||
| outArch=amd64 | ||
| outPath=./output_$outPlattform_$outArch | ||
|
|
||
| rm -rf $outPath | ||
| mkdir $outPath | ||
|
|
||
| CGO_ENABLED=0 GOOS=$outPlattform GOARCH=$outArch go build ../gogs.go | ||
| CGO_ENABLED=0 GOOS=$outPlattform GOARCH=$outArch go build ../main.go |
|
I just updated the |
|
Beside the pending gogs references in scripts it needs a rebase. |
|
Makefile is also outdated 🙂 |
Signed-off-by: Matthias Loibl <[email protected]>
Signed-off-by: Matthias Loibl <[email protected]>
|
Updated my branch with a force push. Rebased against current master and improved all the things said above! 👍 |
Current coverage is 2.18% (diff: 100%)@@ master #33 diff @@
========================================
Files 31 31
Lines 7508 7508
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 164 164
Misses 7327 7327
Partials 17 17
|
|
More references missing, "make" ends with: |
|
Yes, don't touch the makefile, merge this pr :) |
|
LGTM will integrate the makefile and build scripts stuff into my PR. |
|
LGTM |
1 similar comment
|
LGTM |
tboerger
added
the
lgtm/done
Just to stick to the Go rule of thumb for the
main.go.