Skip to content

Fix issue sidebar #32455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix issue sidebar #32455

merged 1 commit into from
Nov 8, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 8, 2024

Fix #32453

Major changes:

  • revert the <div class="divider"></div> in templates/repo/issue/branch_selector_field.tmpl (it was removed by mistake in #Split issue sidebar into small templates #32444)
  • remove incorrect <div class="inline field"> in templates/repo/issue/sidebar/allow_maintainer_edit.tmpl
  • use gt-ellipsis to replace the "title" class in the dependency list, then .repository .issue-content-right .ui.list .title could be removed
  • remove the "relaxed" from dependency list, then there is no padding, then .repository .issue-content-right .ui.list .dependency could be removed (white-space doesn't have effect either because there is gt-ellipsis)
  • remove dead code .repository .issue-content-right #deadlineForm input

The fixed UI should be the same as before.

image

image

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 8, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Nov 8, 2024
@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 8, 2024
@wxiaoguang wxiaoguang added this to the 1.23.0 milestone Nov 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 8, 2024
@wxiaoguang wxiaoguang merged commit d80f99e into go-gitea:main Nov 8, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-sidebar branch November 8, 2024 17:55
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 10, 2024
* giteaofficial/main:
  Refactor sidebar label selector (go-gitea#32460)
  Fix mermaid diagram height when initially hidden (go-gitea#32457)
  Add reviewers selection to new pull request (go-gitea#32403)
  Fix issue sidebar (go-gitea#32455)
  Refactor language menu and dom utils (go-gitea#32450)
  Fix broken releases when re-pushing tags (go-gitea#32435)
  Refactor issue page info (go-gitea#32445)
  Split issue sidebar into small templates (go-gitea#32444)
  Only provide the commit summary for Discord webhook push events (go-gitea#32432)
  Add new event commit status creation and webhook implementation (go-gitea#27151)
  Support quote selected comments to reply (go-gitea#32431)
  Move AddCollabrator and CreateRepositoryByExample to service layer (go-gitea#32419)

# Conflicts:
#	templates/repo/issue/view_content/context_menu.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken padding in issue/pr sidebar
4 participants