Fix markdown URL parsing for commit ID #30812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
added
type/bug
backport/v1.22
wxiaoguang
force-pushed
the
fix-any-hash-parse
branch
from
d6caea7 to
4a11446
Compare
lunny
approved these changes
May 2, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
changed the title
wxiaoguang
force-pushed
the
fix-any-hash-parse
branch
3 times, most recently
from
8646d5d to
9147828
Compare
wxiaoguang
changed the title
wxiaoguang
force-pushed
the
fix-any-hash-parse
branch
from
9147828 to
86abfdc
Compare
KN4CK3R
approved these changes
May 3, 2024
Comment on lines
+431
to
+434
| "http://a/b/c/d/e/1234567812345678123456781234567812345678123456781234567812345678/sub.": { | ||
| CommitID: "1234567812345678123456781234567812345678123456781234567812345678", | ||
| SubPath: "/sub", | ||
| }, |
There was a problem hiding this comment.
This fails with nodes ending with a dot but the ending of a sentence is more likely.
There was a problem hiding this comment.
The behavior is kept from old code, I did some rewriting to make the code clearer and added this test 😁
GiteaBot
added
lgtm/done
KN4CK3R
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 4, 2024
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
added a commit
that referenced
this pull request
May 4, 2024
Backport #30812 by wxiaoguang Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 4, 2024
* giteaofficial/main: Update README.md (go-gitea#30856) Fix markdown URL parsing for commit ID (go-gitea#30812)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some new tests