Skip to content

Fix nil dereference on error (#30740) #30746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix nil dereference on error (#30740) #30746

merged 2 commits into from
Apr 29, 2024

Conversation

wxiaoguang
Copy link
Contributor

Backport #30740 manually

@harryzcy @wxiaoguang
Fix nil dereference on error (go-gitea#30740)
db7c374 
In both cases, the `err` is nil because of `if` checks before

Reference: go-gitea#30729
@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 28, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Apr 28, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 28, 2024
@wxiaoguang wxiaoguang mentioned this pull request Apr 28, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2024
@silverwind silverwind enabled auto-merge (squash) April 28, 2024 23:55
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 28, 2024
@silverwind silverwind merged commit d07019f into go-gitea:release/v1.22 Apr 29, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 29, 2024
@wxiaoguang wxiaoguang deleted the backport-actions-nil branch April 29, 2024 01:03
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

@lng2020 lng2020 lng2020 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
7 participants
@wxiaoguang @lunny @delvh @lng2020 @silverwind @GiteaBot @harryzcy