Skip to content

Fix bugs in issue dashboard stats #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 25, 2017
Merged

Fix bugs in issue dashboard stats #3073

merged 3 commits into from
Dec 25, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Dec 3, 2017 •
edited
Loading

Fixes the following bugs in the issue dashboard:

  • Previously, the "In your Repositories", "Assigned to you" and "Created to you" counts would show the stats for open issues, even if closed issues were selected
  • Previously, the "In your Repositories" count would be incorrect when a repo that is not yours is selected (the count should be 0, because of all the issues currently in view, none are in repos that are yours)
  • Previously, simultaneously selecting "In your Repositories" and a repo that is not yours would result in all the issues in that repo being displayed (no issues should be displayed, since none of the issues in that repo are in repos that are yours)

Also fixes ignored errors in GetUserIssueStats(..), and adds unit tests for affected functionality.

@codecov-io
Copy link

codecov-io commented Dec 3, 2017 •
edited
Loading

Codecov Report

Merging #3073 into master will decrease coverage by 0.22%.
The diff coverage is 53.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3073      +/-   ##
==========================================
- Coverage   34.91%   34.69%   -0.23%     
==========================================
  Files         277      277              
  Lines       40137    40177      +40     
==========================================
- Hits        14015    13938      -77     
- Misses      24069    24195     +126     
+ Partials     2053     2044       -9
Impacted Files Coverage Δ
models/issue_indexer.go 67.81% <0%> (ø) ⬆️
routers/repo/issue.go 32.58% <100%> (ø) ⬆️
routers/api/v1/repo/issue.go 35.68% <100%> (ø) ⬆️
routers/user/home.go 40.56% <47.82%> (-0.22%) ⬇️
models/issue.go 44.29% <54.38%> (-0.54%) ⬇️
modules/lfs/content_store.go 7.81% <0%> (-35.94%) ⬇️
modules/lfs/server.go 20.68% <0%> (-14.33%) ⬇️
modules/indexer/repo.go 60.86% <0%> (-6.96%) ⬇️
models/lfs.go 26.08% <0%> (-2.18%) ⬇️
models/repo_indexer.go 50.97% <0%> (-1.95%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fabf3f2...21f58b0. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 3, 2017
@lunny lunny added this to the 1.x.x milestone Dec 3, 2017
@lunny lunny added the type/bug label Dec 3, 2017
@lafriks lafriks modified the milestones: 1.x.x, 1.4.0 Dec 3, 2017
lunny
lunny requested changes Dec 14, 2017
View reviewed changes
routers/user/home.go
switch filterMode {
case models.FilterModeAll:
opts.RepoIDs = userRepoIDs
if repoID > 0 {
if !com.IsSliceContainsInt64(userRepoIDs, repoID) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com is not import

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, fixed now

@lunny
Copy link
Member

lunny commented Dec 14, 2017

And I didn't find any change on issues page on my local tests.

@ethantkoenig
Copy link
Member Author

@lunny Did you try following the scenarios I listed in the PR description? I see a difference in those scenarios.

@ethantkoenig ethantkoenig force-pushed the fix/issue_stats branch 2 times, most recently from f7acfa8 to 5133559 Compare December 18, 2017 06:02
@ethantkoenig
Copy link
Member Author

@lunny Friendly ping

@lunny
Copy link
Member

lunny commented Dec 25, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 25, 2017
@lafriks
Copy link
Member

lafriks commented Dec 25, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 25, 2017
@lafriks
Copy link
Member

lafriks commented Dec 25, 2017

Oh these random fails :( can you force push?

@ethantkoenig
Copy link
Member Author

@lafriks Do you still need a force push?

@lafriks
Copy link
Member

lafriks commented Dec 25, 2017

@ethantkoenig no, all good :)

@lafriks lafriks merged commit 4c9341f into go-gitea:master Dec 25, 2017
@ethantkoenig ethantkoenig deleted the fix/issue_stats branch January 13, 2018 20:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @codecov-io @lunny @lafriks @tboerger