Skip to content

Conversation

@lunny
Copy link
Member

@lunny lunny commented Mar 21, 2024

This PR will avoid load pullrequest.Issue twice in pull request list page. It will reduce x times database queries for those WIP pull requests.

Partially fix #29585
Backport #29900

This PR will avoid load pullrequest.Issue twice in pull request list
page. It will reduce x times database queries for those WIP pull
requests.

Partially fix go-gitea#29585

---------

Co-authored-by: Giteabot <[email protected]>
@lunny lunny added the performance/speed performance issues with slow downs label Mar 21, 2024
@lunny lunny added this to the 1.21.9 milestone Mar 21, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 21, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2024
@lunny lunny mentioned this pull request Mar 21, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2024
@wolfogre wolfogre merged commit 6ef986d into go-gitea:release/v1.21 Mar 22, 2024
@lunny lunny deleted the lunny/pulls_performance2 branch March 22, 2024 01:58
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files performance/speed performance issues with slow downs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants