Fix error when add user has full name to team #2973
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2973 +/- ##
=========================================
- Coverage 26.82% 26.8% -0.02%
=========================================
Files 90 90
Lines 17807 17807
=========================================
- Hits 4777 4774 -3
- Misses 12351 12353 +2
- Partials 679 680 +1
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
routers/org/teams.go
Outdated
| @@ -76,6 +77,9 @@ func TeamsAction(ctx *context.Context) { | |||
| return | |||
| } | |||
| uname := ctx.Query("uname") | |||
| if strings.Contains(uname, "(") && strings.HasSuffix(uname, ")") { | |||
There was a problem hiding this comment.
I'm confused as to why this helps. If uname has parentheses, then it is not a valid username, so GetUserByName(name) in line 84 will just return a ErrUserNotExist, right?
There was a problem hiding this comment.
@ethantkoenig Yes, that's what #2973 described.
There was a problem hiding this comment.
Because if some user has set FullName, the name submitted will be loginname (FullName) but not loginname, so it will return ErrUserNotExist. This PR will accept both two kinds requests.
There was a problem hiding this comment.
Oh I see. Could we please add a comment explaining the situation?
// uname may be formatted as "username (fullname)"
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
* fix error when add user has full name to team * add comment for extra uname check
|
also fixed #2726 |
Will fix #2962.