Skip to content

Remove DataRaceCheck #29258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Remove DataRaceCheck #29258

merged 2 commits into from
Feb 19, 2024

Conversation

wxiaoguang
Copy link
Contributor

Since #26254, it started using {{ctx.Locale.Tr ...}}

Now the ctx seems stable enough, so the check could be removed.

@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 19, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Feb 19, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 19, 2024 11:01
@wxiaoguang wxiaoguang merged commit 567a68a into go-gitea:main Feb 19, 2024
@wxiaoguang wxiaoguang deleted the remove-ctx-check branch February 20, 2024 14:45
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
Since go-gitea#26254, it started using `{{ctx.Locale.Tr ...}}`

Now the `ctx` seems stable enough, so the check could be removed.
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Feb 26, 2024
Since go-gitea#26254, it started using `{{ctx.Locale.Tr ...}}`

Now the `ctx` seems stable enough, so the check could be removed.

(cherry picked from commit 567a68a)
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants