Improve frontend guideline (#28711) #28713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been a consensus for long time during reviewing: "avoiding inline styles as much as possible".
GiteaBot
added
modifies/docs
skip-changelog
GiteaBot
added
the
lgtm/need 2
yardenshoham
approved these changes
Jan 6, 2024
GiteaBot
removed
the
lgtm/need 2
denyskon
approved these changes
Jan 6, 2024
GiteaBot
added
lgtm/need 1
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #28711 by @wxiaoguang
It has been a consensus for long time during reviewing: "avoiding inline styles as much as possible".
Feel free to improve the wording and/or improve more guidelines.