Improve display of Webauthn keys' creation time #28262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unify how the creation time of webauthn keys are shown with GPG and SSH keys. - Instead of using the time since, show the date that the key was created. Refs: https://codeberg.org/forgejo/forgejo/pulls/1794 (cherry picked from commit 0a2db6215cb10a6bfcb558f5afabc7fba208e3f8)
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/templates
delvh
approved these changes
Nov 28, 2023
GiteaBot
added
lgtm/need 1
|
Is it really good to do so? Before: end users could know the hour/minute/second when hover on the "time" Now: end users could only know the "year/month/day" , but they wouldn't be able to know the detailed time. |
KN4CK3R
pushed a commit
that referenced
this pull request
Jan 2, 2024
There was a question about "how to improve the datetime display for SSH/PGP/WebAuthn" #28262 (comment) The root problem is that `DateTime` misses the "data-tooltip-content" attribute, which should be used to make the tooltip popup smoothly. Now the UI is consistent and the end users could see the detailed hour/minute/second easily by hovering the element.  
|
No response for long time. The question has been answered by Make template DateTime show proper tooltip #28677 . The root problem is that some attributes are missing for |
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
There was a question about "how to improve the datetime display for SSH/PGP/WebAuthn" go-gitea#28262 (comment) The root problem is that `DateTime` misses the "data-tooltip-content" attribute, which should be used to make the tooltip popup smoothly. Now the UI is consistent and the end users could see the detailed hour/minute/second easily by hovering the element.  
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
There was a question about "how to improve the datetime display for SSH/PGP/WebAuthn" go-gitea#28262 (comment) The root problem is that `DateTime` misses the "data-tooltip-content" attribute, which should be used to make the tooltip popup smoothly. Now the UI is consistent and the end users could see the detailed hour/minute/second easily by hovering the element.  
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://codeberg.org/forgejo/forgejo/pulls/1794
(cherry picked from commit 0a2db6215cb10a6bfcb558f5afabc7fba208e3f8)