Add cancel button to wiki #28261
Closed
Add cancel button to wiki #28261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a cancel button to the Edit and New wiki pages. - Resolves https://codeberg.org/forgejo/forgejo/issues/705 (cherry picked from commit 9f8bf83b0e7845a44ca91bc8497356dbab059374)
GiteaBot
added
the
lgtm/need 2
delvh
reviewed
Nov 28, 2023
| @@ -1882,6 +1882,7 @@ wiki.page_title = Page title | |||
| wiki.page_content = Page content | |||
| wiki.default_commit_message = Write a note about this page update (optional). | |||
| wiki.save_page = Save Page | |||
| wiki.cancel = Cancel | |||
There was a problem hiding this comment.
Occurrence number 12 of the regex = Cancel$ in this file 🎉
Jokes aside, should we perhaps use one common key for it instead of adding the same key every time?
There was a problem hiding this comment.
Definitely! That's the plan for the locale cleanup anyway
|
Fix #24036 |
|
Although this PR is
|
|
@earl-warren Please make the requested changes |
denyskon
added
the
issue/needs-feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 9f8bf83b0e7845a44ca91bc8497356dbab059374)