Skip to content

Fix the overflow style for "Hide all checks" #27932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 7, 2023
Merged
1 change: 1 addition & 0 deletions web_src/css/modules/tippy.css
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@

.tippy-box[data-theme="box-with-header"] .tippy-content {
background: var(--color-box-body);
border-radius: var(--border-radius);
padding: 0;
}

Expand Down
16 changes: 12 additions & 4 deletions web_src/css/repo.css
Original file line number Diff line number Diff line change
Expand Up @@ -3075,21 +3075,29 @@ tbody.commit-list {
}

.commit-status-header {
border: none !important; /* reset the default ".ui.attached.header" styles, to use the outer border */
margin: 0 !important;
/* reset the default ".ui.attached.header" styles, to use the outer border */
border: none !important;
/* add a bottom border to make sure the there is always a divider between the header and list when the list is scrolling */
border-bottom: 1px solid var(--color-secondary) !important;
/* use negative margin to avoid the newly added border conflict with the list's top border */
margin: 0 0 -1px !important;
}

.commit-status-list {
max-height: 195px; /* fit exactly 4 items */
max-height: 240px; /* fit exactly 6 items, commit-status-item.height * 6 */
overflow-x: hidden;
transition: max-height .2s;
}

.commit-status-item {
padding: 14px 10px !important;
height: 40px;
padding: 0 10px;
display: flex;
gap: 8px;
align-items: center;
}

.commit-status-item + .commit-status-item {
border-top: 1px solid var(--color-secondary);
}

Expand Down
2 changes: 0 additions & 2 deletions web_src/js/features/repo-issue-pr-status.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ export function initRepoPullRequestCommitStatus() {
const list = panel.querySelector('.commit-status-list');
btn.addEventListener('click', () => {
list.style.maxHeight = list.style.maxHeight ? '' : '0px'; // toggle
list.style.overflow = 'hidden'; // hide scrollbar when hiding
btn.textContent = btn.getAttribute(list.style.maxHeight ? 'data-show-all' : 'data-hide-all');
});
list.addEventListener('animationend', () => list.style.overflow = '');
}
}