Add reverseproxy auth for API back with default disabled #26703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
|
cc: @pboguslawski as this is likely relevant to your interests |
silverwind
reviewed
Aug 24, 2023
silverwind
approved these changes
Aug 25, 2023
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
LGTM. But I would like the author and reviewers of #22219 (@zeripath @jolheiser @delvh) to take a look.
GiteaBot
added
lgtm/done
wolfogre
added
the
status/blocked
delvh
reviewed
Sep 4, 2023
jolheiser
approved these changes
Sep 4, 2023
delvh
approved these changes
Sep 4, 2023
|
I think we can continue since @zeripath has no response for 3 days. |
lunny
added
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 8, 2023
* giteaofficial/main: Add `yamllint` (go-gitea#26965) Fix yaml quoting (go-gitea#26964) [skip ci] Updated translations via Crowdin Add `actions/labeler` (go-gitea#26962) Team invite url fix when registration disabled (go-gitea#26950) Refactor dashboard/feed.tmpl (go-gitea#26956) Improve hint when uploading a too large avatar (go-gitea#26935) Replace `util.SliceXxx` with `slices.Xxx` (go-gitea#26958) Add reverseproxy auth for API back with default disabled (go-gitea#26703) Add "dir=auto" for input/textarea elements by default (go-gitea#26735)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was removed by #22219 to avoid possible CSRF attack.
This PR takes reverseproxy auth for API back but with default disabled.
To prevent possbile CSRF attack, the responsibility will be the reverseproxy but not Gitea itself.
For those want to enable this
ENABLE_REVERSE_PROXY_AUTHENTICATION_API, they should know what they are doing.