[WIP] Improve CommitStatus #26247
Closed
[WIP] Improve CommitStatus #26247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
CaiCandong
reviewed
Aug 1, 2023
templates/repo/commit_status.tmpl
Outdated
| {{svg "gitea-exclamation" 18 "commit-status icon text red"}} | ||
| {{end}} | ||
| {{if eq .State "failure"}} | ||
| {{if eq .State 2}} |
There was a problem hiding this comment.
I believe that using direct numbers for judgment here leads to poor code readability and maintainability. My opinion is to continue using the previous code on the frontend page.When passing the state to the frontend, perform a conversion from numbers to strings.
There was a problem hiding this comment.
Ah, forgot that we have CommitStatusState.IsXXXX.
I think this is the best solution.
| } | ||
|
|
||
| // NoBetterThan returns true if this State is no better than the given State | ||
| // This function only handles the states defined in CommitStatusPriorities | ||
| func (css CommitStatusState) NoBetterThan(css2 CommitStatusState) bool { |
There was a problem hiding this comment.
This requires checking for special values, enhancing the robustness of the function, and avoiding issues caused by incorrect usage by the caller, as seen in #26121.
There was a problem hiding this comment.
Finally, I want to remove this function.
It is only used in MergeRequiredContextsCommitStatus. But have no good idea about how to rewrite it now.
Or maybe I will add CommitStatusState.IsValid which should be called before we compare them.
silverwind
added a commit
that referenced
this pull request
Nov 2, 2023
Step one for a GitHub like commit status check ui:    Step two:   The design now will list all commit status checks which takes too much space. This is a pre-improve for #26247 --------- Co-authored-by: delvh <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
) Step one for a GitHub like commit status check ui:    Step two:   The design now will list all commit status checks which takes too much space. This is a pre-improve for go-gitea#26247 --------- Co-authored-by: delvh <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
) Step one for a GitHub like commit status check ui:    Step two:   The design now will list all commit status checks which takes too much space. This is a pre-improve for go-gitea#26247 --------- Co-authored-by: delvh <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #25990 (comment)
Fix #25990
Changes:
Intto save CommitStatus in DBminin sql to get the CommitStatus instead of calculate CommitStatus in Gitea side