WIP: Add rpm support for multiple distributions

docs/content/usage/packages/rpm.en-us.md

@@ -27,17 +27,18 @@ The following examples use `dnf`.
 To register the RPM registry add the url to the list of known apt sources:
 
 ```shell
-dnf config-manager --add-repo https://gitea.example.com/api/packages/{owner}/rpm.repo
+dnf config-manager --add-repo https://gitea.example.com/api/packages/{owner}/rpm/{distribution}.repo
 ```
 
 | Placeholder | Description |
 | ----------- | ----------- |
 | `owner`     | The owner of the package. |
+| `distribution` | Package group name, e.g. `el7`, `el9` , `test-el9`. |
 
 If the registry is private, provide credentials in the url. You can use a password or a [personal access token](development/api-usage.md#authentication):
 
 ```shell
-dnf config-manager --add-repo https://{username}:{your_password_or_token}@gitea.example.com/api/packages/{owner}/rpm.repo
+dnf config-manager --add-repo https://{username}:{your_password_or_token}@gitea.example.com/api/packages/{owner}/rpm/{distribution}.repo
 ```
 
 You have to add the credentials to the urls in the `rpm.repo` file in `/etc/yum.repos.d` too.
@@ -47,19 +48,20 @@ You have to add the credentials to the urls in the `rpm.repo` file in `/etc/yum.
 To publish a RPM package (`*.rpm`), perform a HTTP PUT operation with the package content in the request body.
 
 ```
-PUT https://gitea.example.com/api/packages/{owner}/rpm/upload
+PUT https://gitea.example.com/api/packages/{owner}/rpm/{distribution}/upload
 ```
 
 | Parameter | Description |
 | --------- | ----------- |
 | `owner`   | The owner of the package. |
+| `distribution` | Package group name, e.g. `el7`, `el9` , `test-el9`. |
 
 Example request using HTTP Basic authentication:
 
 ```shell
 curl --user your_username:your_password_or_token \
      --upload-file path/to/file.rpm \
-     https://gitea.example.com/api/packages/testuser/rpm/upload
+     https://gitea.example.com/api/packages/testuser/rpm/default/upload
 ```
 
 If you are using 2FA or OAuth use a [personal access token](development/api-usage.md#authentication) instead of the password.
@@ -78,12 +80,13 @@ The server responds with the following HTTP Status codes.
 To delete an RPM package perform a HTTP DELETE operation. This will delete the package version too if there is no file left.
 
 ```
-DELETE https://gitea.example.com/api/packages/{owner}/rpm/{package_name}/{package_version}/{architecture}
+DELETE https://gitea.example.com/api/packages/{owner}/rpm/{distribution}/package/{package_name}/{package_version}/{architecture}
 ```
 
 | Parameter         | Description |
 | ----------------- | ----------- |
 | `owner`           | The owner of the package. |
+| `distribution`    | The package distribution. |
 | `package_name`    | The package name. |
 | `package_version` | The package version. |
 | `architecture`    | The package architecture. |
@@ -92,7 +95,7 @@ Example request using HTTP Basic authentication:
 
 ```shell
 curl --user your_username:your_token_or_password -X DELETE \
-     https://gitea.example.com/api/packages/testuser/rpm/test-package/1.0.0/x86_64
+     https://gitea.example.com/api/packages/testuser/rpm/default/test-package/1.0.0/x86_64
 ```
 
 The server responds with the following HTTP Status codes.

docs/content/usage/packages/rpm.zh-cn.md

@@ -27,17 +27,18 @@ menu:
 要注册RPM注册表，请将 URL 添加到已知 `apt` 源列表中：
 
 ```shell
-dnf config-manager --add-repo https://gitea.example.com/api/packages/{owner}/rpm.repo
+dnf config-manager --add-repo https://gitea.example.com/api/packages/{owner}/rpm/{distribution}.repo
 ```
 
 | 占位符  | 描述           |
 | ------- | -------------- |
 | `owner` | 软件包的所有者 |
+| `distribution` | 一个任意的名称，例如：el7、el9 |
 
 如果注册表是私有的，请在URL中提供凭据。您可以使用密码或[个人访问令牌](development/api-usage.md#通过-api-认证)：
 
 ```shell
-dnf config-manager --add-repo https://{username}:{your_password_or_token}@gitea.example.com/api/packages/{owner}/rpm.repo
+dnf config-manager --add-repo https://{username}:{your_password_or_token}@gitea.example.com/api/packages/{owner}/rpm/{distribution}.repo
 ```
 
 您还必须将凭据添加到 `/etc/yum.repos.d` 中的 `rpm.repo` 文件中的URL中。
@@ -47,19 +48,20 @@ dnf config-manager --add-repo https://{username}:{your_password_or_token}@gitea.
 要发布RPM软件包（`*.rpm`），请执行带有软件包内容的 HTTP `PUT` 操作。
 
 ```
-PUT https://gitea.example.com/api/packages/{owner}/rpm/upload
+PUT https://gitea.example.com/api/packages/{owner}/rpm/{distribution}/upload
 ```
 
 | 参数    | 描述           |
 | ------- | -------------- |
 | `owner` | 软件包的所有者 |
+| `distribution` | 软件包组名称，例如：`el7`、`el9`、`test-el9` |
 
 使用HTTP基本身份验证的示例请求：
 
 ```shell
 curl --user your_username:your_password_or_token \
      --upload-file path/to/file.rpm \
-     https://gitea.example.com/api/packages/testuser/rpm/upload
+     https://gitea.example.com/api/packages/testuser/rpm/default/upload
 ```
 
 如果您使用 2FA 或 OAuth，请使用[个人访问令牌](development/api-usage.md#通过-api-认证)替代密码。您无法将具有相同名称的文件两次发布到软件包中。您必须先删除现有的软件包版本。
@@ -77,12 +79,13 @@ curl --user your_username:your_password_or_token \
 要删除 RPM 软件包，请执行 HTTP `DELETE` 操作。如果没有文件剩余，这也将删除软件包版本。
 
 ```
-DELETE https://gitea.example.com/api/packages/{owner}/rpm/{package_name}/{package_version}/{architecture}
+DELETE https://gitea.example.com/api/packages/{owner}/rpm/{distribution}/package/{package_name}/{package_version}/{architecture}
 ```
 
 | 参数              | 描述           |
 | ----------------- | -------------- |
 | `owner`           | 软件包的所有者 |
+| `distribution`    | 软件包组名称  |
 | `package_name`    | 软件包名称     |
 | `package_version` | 软件包版本     |
 | `architecture`    | 软件包架构     |
@@ -91,7 +94,7 @@ DELETE https://gitea.example.com/api/packages/{owner}/rpm/{package_name}/{packag
 
 ```shell
 curl --user your_username:your_token_or_password -X DELETE \
-     https://gitea.example.com/api/packages/testuser/rpm/test-package/1.0.0/x86_64
+     https://gitea.example.com/api/packages/testuser/rpm/default/package/test-package/1.0.0/x86_64
 ```
 
 服务器将以以下HTTP状态码响应：

models/migrations/migrations.go

@@ -528,6 +528,8 @@ var migrations = []Migration{
 	NewMigration("Add Version to ActionRun table", v1_21.AddVersionToActionRunTable),
 	// v273 -> v274
 	NewMigration("Add Action Schedule Table", v1_21.AddActionScheduleTable),
+	// v274 -> v275
+	NewMigration("Migrate old rpm package index", v1_21.RebuildRpmPackage),
 }
 
 // GetCurrentDBVersion returns the current db version

models/migrations/v1_21/v274.go

@@ -0,0 +1,81 @@
+// Copyright 2023 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package v1_21 //nolint
+
+import (
+	"code.gitea.io/gitea/modules/json"
+	"code.gitea.io/gitea/modules/packages/rpm"
+
+	"xorm.io/xorm"
+)
+
+func RebuildRpmPackage(x *xorm.Engine) error {
+	sess := x.NewSession()
+	defer sess.Close()
+	defaultDistribution := rpm.RepositoryDefaultDistribution
+	// select all old rpm package
+	var oldRpmIds []int64
+	ss := sess.Cols("id").
+		Table("package_file").
+		Where("composite_key = ?", "").
+		And("lower_name like ?", "%.rpm")
+	err := ss.Find(&oldRpmIds)
+	if err != nil {
+		return err
+	}
+	// add metadata
+	// NOTE: package_property[name='rpm.metdata'] is very large,
+	// and to avoid querying all of them resulting in large memory,
+	// a single RPM package is now used for updating.
+	for _, id := range oldRpmIds {
+
+		metadata := make([]string, 0, 3)
+		_, err := sess.Cols("ref_type", "ref_id", "value").
+			Table("package_property").
+			Where("name = 'rpm.metdata'").
+			And("ref_id = ?", id).
+			Get(&metadata)
+		if err != nil {
+			return err
+		}
+		// get rpm info
+		var rpmMetadata rpm.FileMetadata
+		err = json.Unmarshal([]byte(metadata[2]), &rpmMetadata)
+		if err != nil {
+			return err
+		}
+		_, err = sess.Exec(
+			"INSERT INTO package_property(ref_type, ref_id, name, value) values (?,?,?,?),(?,?,?,?)",
+			metadata[0], metadata[1], "rpm.distribution", defaultDistribution,
+			metadata[0], metadata[1], "rpm.architecture", rpmMetadata.Architecture,
+		)
+		if err != nil {
+			return err
+		}
+		// set default distribution
+		_, err = sess.Table("package_file").
+			Where("id = ?", id).
+			Update(map[string]any{
+				"composite_key": defaultDistribution,
+			})
+		if err != nil {
+			return err
+		}
+	}
+	// set old rpm index file to default distribution
+	_, err = sess.Table("package_file").
+		Where(
+			"composite_key = '' AND " +
+				"lower_name IN" +
+				"(" +
+				"'primary.xml.gz','other.xml.gz','filelists.xml.gz','other.xml.gz','repomd.xml','repomd.xml.asc'" +
+				")").
+		Update(map[string]any{
+			"composite_key": defaultDistribution,
+		})
+	if err != nil {
+		return err
+	}
+	return nil
+}

modules/packages/rpm/metadata.go

@@ -15,13 +15,17 @@ import (
 )
 
 const (
-	PropertyMetadata = "rpm.metadata"
+	PropertyMetadata     = "rpm.metadata"
+	PropertyDistribution = "rpm.distribution"
+	PropertyArchitecture = "rpm.architecture"
 
 	SettingKeyPrivate = "rpm.key.private"
 	SettingKeyPublic  = "rpm.key.public"
 
 	RepositoryPackage = "_rpm"
 	RepositoryVersion = "_repository"
+
+	RepositoryDefaultDistribution = "default"
 )
 
 const (

options/locale/locale_en-US.ini

@@ -3381,6 +3381,11 @@ rpm.registry = Setup this registry from the command line:
 rpm.distros.redhat = on RedHat based distributions
 rpm.distros.suse = on SUSE based distributions
 rpm.install = To install the package, run the following command:
+rpm.package.info = Package Info
+rpm.package.distributions = Distributions
+rpm.package.architectures = Architectures
+rpm.package.description = Description
+rpm.package.summary = Summary
 rubygems.install = To install the package using gem, run the following command:
 rubygems.install2 = or add it to the Gemfile:
 rubygems.dependencies.runtime = Runtime Dependencies

routers/api/packages/api.go

@@ -513,14 +513,25 @@ func CommonRoutes() *web.Route {
 			r.Get("/simple/{id}", pypi.PackageMetadata)
 		}, reqPackageAccess(perm.AccessModeRead))
 		r.Group("/rpm", func() {
-			r.Get(".repo", rpm.GetRepositoryConfig)
+			r.Get(".repo", func(ctx *context.Context) {
+				ctx.Redirect(setting.AppSubURL + strings.Replace(ctx.Base.Req.URL.Path, "/rpm.repo", "/rpm/default.repo", 1))
+			})
+			r.Get("/repodata/{filename}", func(ctx *context.Context) {
+				ctx.Redirect(setting.AppSubURL + strings.Replace(ctx.Base.Req.URL.Path, "/rpm/repodata/", "/rpm/default/repodata/", 1))
+			})
+			r.Get("/package/{name}/{version}/{architecture}", func(ctx *context.Context) {
+				ctx.Redirect(setting.AppSubURL + strings.Replace(ctx.Base.Req.URL.Path, "/rpm/package/", "/rpm/default/package/", 1))
+			})
 			r.Get("/repository.key", rpm.GetRepositoryKey)
-			r.Put("/upload", reqPackageAccess(perm.AccessModeWrite), rpm.UploadPackageFile)
-			r.Group("/package/{name}/{version}/{architecture}", func() {
-				r.Get("", rpm.DownloadPackageFile)
-				r.Delete("", reqPackageAccess(perm.AccessModeWrite), rpm.DeletePackageFile)
+			r.Group("/{distribution}", func() {
+				r.Get(".repo", rpm.GetRepositoryConfig)
+				r.Put("/upload", reqPackageAccess(perm.AccessModeWrite), rpm.UploadPackageFile)
+				r.Group("/package/{name}/{version}/{architecture}", func() {
+					r.Get("", rpm.DownloadPackageFile)
+					r.Delete("", reqPackageAccess(perm.AccessModeWrite), rpm.DeletePackageFile)
+				})
+				r.Get("/repodata/{filename}", rpm.GetRepositoryFile)
 			})
-			r.Get("/repodata/{filename}", rpm.GetRepositoryFile)
 		}, reqPackageAccess(perm.AccessModeRead))
 		r.Group("/rubygems", func() {
 			r.Get("/specs.4.8.gz", rubygems.EnumeratePackages)

routers/api/packages/rpm/rpm.go

@@ -33,11 +33,12 @@ func apiError(ctx *context.Context, status int, obj any) {
 
 // https://dnf.readthedocs.io/en/latest/conf_ref.html
 func GetRepositoryConfig(ctx *context.Context) {
+	distribution := ctx.Params("distribution")
 	url := fmt.Sprintf("%sapi/packages/%s/rpm", setting.AppURL, ctx.Package.Owner.Name)
 
-	ctx.PlainText(http.StatusOK, `[gitea-`+ctx.Package.Owner.LowerName+`]
-name=`+ctx.Package.Owner.Name+` - `+setting.AppName+`
-baseurl=`+url+`
+	ctx.PlainText(http.StatusOK, `[gitea-`+ctx.Package.Owner.LowerName+`-`+distribution+`]
+name=`+ctx.Package.Owner.Name+` - `+setting.AppName+` - `+distribution+`
+baseurl=`+url+`/`+distribution+`
 enabled=1
 gpgcheck=1
 gpgkey=`+url+`/repository.key`)
@@ -69,7 +70,8 @@ func GetRepositoryFile(ctx *context.Context) {
 		ctx,
 		pv,
 		&packages_service.PackageFileInfo{
-			Filename: ctx.Params("filename"),
+			Filename:     ctx.Params("filename"),
+			CompositeKey: ctx.Params("distribution"),
 		},
 	)
 	if err != nil {
@@ -121,7 +123,7 @@ func UploadPackageFile(ctx *context.Context) {
 		apiError(ctx, http.StatusInternalServerError, err)
 		return
 	}
-
+	distribution := ctx.Params("distribution")
 	_, _, err = packages_service.CreatePackageOrAddFileToExisting(
 		&packages_service.PackageCreationInfo{
 			PackageInfo: packages_service.PackageInfo{
@@ -135,13 +137,16 @@ func UploadPackageFile(ctx *context.Context) {
 		},
 		&packages_service.PackageFileCreationInfo{
 			PackageFileInfo: packages_service.PackageFileInfo{
-				Filename: fmt.Sprintf("%s-%s.%s.rpm", pck.Name, pck.Version, pck.FileMetadata.Architecture),
+				Filename:     fmt.Sprintf("%s-%s.%s.rpm", pck.Name, pck.Version, pck.FileMetadata.Architecture),
+				CompositeKey: distribution,
 			},
 			Creator: ctx.Doer,
 			Data:    buf,
 			IsLead:  true,
 			Properties: map[string]string{
-				rpm_module.PropertyMetadata: string(fileMetadataRaw),
+				rpm_module.PropertyMetadata:     string(fileMetadataRaw),
+				rpm_module.PropertyDistribution: distribution,
+				rpm_module.PropertyArchitecture: pck.FileMetadata.Architecture,
 			},
 		},
 	)
@@ -157,7 +162,7 @@ func UploadPackageFile(ctx *context.Context) {
 		return
 	}
 
-	if err := rpm_service.BuildRepositoryFiles(ctx, ctx.Package.Owner.ID); err != nil {
+	if err := rpm_service.BuildRepositoryFiles(ctx, ctx.Package.Owner.ID, distribution); err != nil {
 		apiError(ctx, http.StatusInternalServerError, err)
 		return
 	}
@@ -168,7 +173,6 @@ func UploadPackageFile(ctx *context.Context) {
 func DownloadPackageFile(ctx *context.Context) {
 	name := ctx.Params("name")
 	version := ctx.Params("version")
-
 	s, u, pf, err := packages_service.GetFileStreamByPackageNameAndVersion(
 		ctx,
 		&packages_service.PackageInfo{
@@ -178,7 +182,8 @@ func DownloadPackageFile(ctx *context.Context) {
 			Version:     version,
 		},
 		&packages_service.PackageFileInfo{
-			Filename: fmt.Sprintf("%s-%s.%s.rpm", name, version, ctx.Params("architecture")),
+			Filename:     fmt.Sprintf("%s-%s.%s.rpm", name, version, ctx.Params("architecture")),
+			CompositeKey: ctx.Params("distribution"),
 		},
 	)
 	if err != nil {
@@ -197,6 +202,7 @@ func DeletePackageFile(webctx *context.Context) {
 	name := webctx.Params("name")
 	version := webctx.Params("version")
 	architecture := webctx.Params("architecture")
+	distribution := webctx.Params("distribution")
 
 	var pd *packages_model.PackageDescriptor
 
@@ -210,7 +216,7 @@ func DeletePackageFile(webctx *context.Context) {
 			ctx,
 			pv.ID,
 			fmt.Sprintf("%s-%s.%s.rpm", name, version, architecture),
-			packages_model.EmptyFileKey,
+			distribution,
 		)
 		if err != nil {
 			return err
@@ -250,7 +256,7 @@ func DeletePackageFile(webctx *context.Context) {
 		notification.NotifyPackageDelete(webctx, webctx.Doer, pd)
 	}
 
-	if err := rpm_service.BuildRepositoryFiles(webctx, webctx.Package.Owner.ID); err != nil {
+	if err := rpm_service.BuildRepositoryFiles(webctx, webctx.Package.Owner.ID, distribution); err != nil {
 		apiError(webctx, http.StatusInternalServerError, err)
 		return
 	}