Skip to content

hard code oauth app git-credential-oauth #25774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

hard code oauth app git-credential-oauth #25774

wants to merge 1 commit into from

Conversation

hickford
Copy link
Contributor

@hickford hickford commented Jul 8, 2023

Fixes #25189

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2023
@hickford hickford changed the title hard code oauth2 app git-credential-oauth hard code oauth app git-credential-oauth Jul 8, 2023
@hickford hickford mentioned this pull request Jul 8, 2023
Closed
@hickford
Copy link
Contributor Author

hickford commented Jul 8, 2023

Tested with hickford/git-credential-oauth#28 and it works

@hickford hickford mentioned this pull request Jul 8, 2023
Closed
6543
6543 requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcode ?!?

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 9, 2023
@wxiaoguang
Copy link
Contributor

Hard-coding seems an interesting idea, but I think some questions should be answered first:

  1. How to document it and how to display it?
  2. How to disable it?

It doesn't seem easy to maintain hard-coded oauth2 application

@hickford
Copy link
Contributor Author

hickford commented Jul 9, 2023

While authentication works, I think it will be buggy, because the application is missing the unique ID field.

For instance, the application is missing under Authorized OAuth2 Applications

@hickford hickford marked this pull request as draft July 9, 2023 06:43
@hickford hickford closed this Jul 9, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 requested changes

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preconfigure Git Credential Manager as instance-wide OAuth application
4 participants
@hickford @wxiaoguang @6543 @GiteaBot