Fix sub-command log level #25537
Merged
Fix sub-command log level #25537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-cmd-log-level
branch
from
6cd6447 to
62962a3
Compare
wxiaoguang
force-pushed
the
fix-cmd-log-level
branch
from
62962a3 to
caedb95
Compare
wxiaoguang
force-pushed
the
fix-cmd-log-level
branch
from
caedb95 to
896767a
Compare
wxiaoguang
force-pushed
the
fix-cmd-log-level
branch
from
896767a to
45ad766
Compare
silverwind
approved these changes
Jun 27, 2023
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Jun 28, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Closed
wxiaoguang
added a commit
to wxiaoguang/gitea
that referenced
this pull request
Jun 28, 2023
More fix for go-gitea#24981 * go-gitea#24981 Close go-gitea#22361 * go-gitea#22361 There were many patches for Gitea's sub-commands to satisfy the facts: * Some sub-commands shouldn't output any log, otherwise the git protocol would be broken * Sometimes the users want to see "verbose" or "quiet" outputs That's a longstanding problem, and very fragile. This PR is only a quick patch for the problem. In the future, the sub-command system should be refactored to a clear solution. ---- Other changes: * Use `ReplaceAllWriters` to replace `RemoveAllWriters().AddWriters(writer)`, then it's an atomic operation. * Remove unnecessary `syncLevelInternal` calls, because `AddWriters/addWritersInternal` already calls it. Co-authored-by: Giteabot <[email protected]>
wxiaoguang
added
the
backport/manual
lunny
pushed a commit
that referenced
this pull request
Jun 28, 2023
Backport #25537 More fix for #24981 * #24981 Close #22361, #25552 * #22361 * #25552 There were many patches for Gitea's sub-commands to satisfy the facts: * Some sub-commands shouldn't output any log, otherwise the git protocol would be broken * Sometimes the users want to see "verbose" or "quiet" outputs That's a longstanding problem, and very fragile. This PR is only a quick patch for the problem. In the future, the sub-command system should be refactored to a clear solution. ---- Other changes: * Use `ReplaceAllWriters` to replace `RemoveAllWriters().AddWriters(writer)`, then it's an atomic operation. * Remove unnecessary `syncLevelInternal` calls, because `AddWriters/addWritersInternal` already calls it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fix for #24981
Close #22361
--quietis not usable as a global option withgitea web#22361There were many patches for Gitea's sub-commands to satisfy the facts:
That's a longstanding problem, and very fragile. This PR is only a quick patch for the problem.
In the future, the sub-command system should be refactored to a clear solution.
Other changes:
ReplaceAllWritersto replaceRemoveAllWriters().AddWriters(writer), then it's an atomic operation.syncLevelInternalcalls, becauseAddWriters/addWritersInternalalready calls it.