Skip to content

Refactor web package and context package #25298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 18, 2023
Merged

Refactor web package and context package #25298

merged 5 commits into from
Jun 18, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 16, 2023 •
edited
Loading

  1. The "web" package shouldn't depends on "modules/context" package, instead, let each "web context" register themselves to the "web" package.
  2. The old Init/Free doesn't make sense, so simplify it
    • The ctx in "Init(ctx)" is never used, and shouldn't be used that way
    • The "Free" is never called and shouldn't be called because the SSPI instance is shared

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 16, 2023
@wxiaoguang wxiaoguang force-pushed the refactor-context branch 5 times, most recently from d8aae05 to 1d0abd1 Compare June 16, 2023 04:45
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 18, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 18, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 18, 2023
@silverwind silverwind merged commit 4e2f1ee into go-gitea:main Jun 18, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 18, 2023
@wxiaoguang wxiaoguang deleted the refactor-context branch June 18, 2023 14:48
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 19, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5eceb8d 
* giteaofficial/main: (22 commits)
  Only run `docker-dryrun` when necessary (go-gitea#25329)
  fix a nit error output in Makefile (go-gitea#25360)
  [skip ci] Updated translations via Crowdin
  Clean up pyproject.toml and package.json, fix poetry options (go-gitea#25327)
  Fix label list divider (go-gitea#25312)
  Avoid polluting the config (go-gitea#25345)
  Fix incorrect link-action event target (go-gitea#25306)
  Write absolute AppDataPath to app.ini when installing (go-gitea#25331)
  Add Exoscale to installation on cloud provider docs (go-gitea#25342)
  Fix UI on mobile view (go-gitea#25315)
  When viewing a file, hide the add button (go-gitea#25320)
  Update JS dependencies, remove space after emoji completion (go-gitea#25266)
  Refactor web package and context package (go-gitea#25298)
  build nightly docker images (go-gitea#25317)
  Add `stylelint-declaration-block-no-ignored-properties` (go-gitea#25284)
  Remove EasyMDE focus outline on text (go-gitea#25328)
  use Actions environment variables in Makefile (go-gitea#25319)
  add `stylelint-stylistic` (go-gitea#25285)
  Remove more unused Fomantic variants (go-gitea#25292)
  Build nightly binaries with Actions (go-gitea#25308)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @silverwind @GiteaBot