Fix visibility of organization repositories #2400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We shouldn't assume that the searcher doesn't have access to any of the privates repos in his/her organizations. For instance, the searcher might be the owner of an organization, and therefore should have access to that organization's private repos. |
tboerger
added
the
lgtm/need 2
|
@ethantkoenig I did tests before pushing this PR. It's working because if you are owner or any type of member with rights to repositories, you are in "access" table (I was also checking DB table). So this is perfectly fine and you see everything you should see. |
|
That means, if you use |
Morlinest
force-pushed
the
fix/search-repository-access-rights
branch
from
2635927 to
6017733
Compare
|
Closing in favor of #2371. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2399.