Skip to content

Add missing forks key for dashboard repository component #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Aug 17, 2017

Missing key that is used in #2285

@lafriks lafriks added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 17, 2017
@lafriks lafriks added this to the 1.2.0 milestone Aug 17, 2017
@appleboy
Copy link
Member

appleboy commented Aug 17, 2017

@lafriks Please don't push your branch to Gitea repo since it will trigger push event in Drone. Otherwise LGTM

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2017
@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2017
@lafriks
Copy link
Member Author

lafriks commented Aug 17, 2017

@appleboy it was by accident. When editing from github web it was creating new branch in my forked repository previously but now that I'm member on gitea org it seams to create branch in gitea repo :(

@appleboy
Copy link
Member

@lafriks Yes. so I don't try to edit the file from GitHub web. :)

@lunny
Copy link
Member

lunny commented Aug 18, 2017

@lafriks there was already forks key in line 480.

@lafriks
Copy link
Member Author

lafriks commented Aug 18, 2017

@lunny but it is in different scope (forks as used for tab in component vs repo.forks - key that already exists and used for page header in forks page)

@lunny
Copy link
Member

lunny commented Aug 18, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 18, 2017
@lunny lunny merged commit 9df090e into master Aug 18, 2017
@lafriks lafriks deleted the lafriks-patch-1 branch August 18, 2017 06:56
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants