Skip to content

Add comment marking the end of database migrations in 1.19.0 #22975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

yardenshoham
Copy link
Member

There will be no more migrations in 1.19.0

There will be no more migrations in 1.19.0
@yardenshoham yardenshoham added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 18, 2023
@yardenshoham yardenshoham added this to the 1.19.0 milestone Feb 18, 2023
@yardenshoham yardenshoham requested a review from delvh February 18, 2023 21:02
Signed-off-by: Yarden Shoham <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #22975 (c4957a3) into main (c8093a1) will increase coverage by 0.10%.
The diff coverage is 55.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #22975      +/-   ##
==========================================
+ Coverage   47.29%   47.40%   +0.10%     
==========================================
  Files        1113     1139      +26     
  Lines      150159   150708     +549     
==========================================
+ Hits        71023    71444     +421     
- Misses      70700    70804     +104     
- Partials     8436     8460      +24     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <ø> (ø)
cmd/admin_user_change_password.go 0.00% <0.00%> (ø)
cmd/admin_user_create.go 0.00% <0.00%> (ø)
cmd/admin_user_delete.go 0.00% <0.00%> (ø)
cmd/admin_user_generate_access_token.go 0.00% <0.00%> (ø)
cmd/admin_user_list.go 0.00% <0.00%> (ø)
cmd/admin_user_must_change_password.go 0.00% <0.00%> (ø)
cmd/cmd.go 40.00% <0.00%> (-0.75%) ⬇️
cmd/convert.go 0.00% <0.00%> (ø)
cmd/doctor.go 0.00% <0.00%> (ø)
... and 226 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2023
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm holding it back until the feature freeze has actually passed, on the rare chance that we still merge another feature today.

@yardenshoham
Copy link
Member Author

I think it's time

@delvh
Copy link
Member

delvh commented Feb 19, 2023

No, there are still two hours until feature freeze (https://discord.com/channels/322538954119184384/537668686173962260/1074769294090579998).
Especially #21563 could potentially still be merged.
However, I haven't reviewed the PR yet, I don't know if it is ready, so I'll leave it to those that reviewed it.

@yardenshoham
Copy link
Member Author

yardenshoham commented Feb 19, 2023

I have to log off now, if #21563 gets merged feel free to push to this branch/replace this PR

@delvh delvh self-requested a review February 20, 2023 00:00
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 20, 2023
@lunny lunny merged commit 6840a8c into go-gitea:main Feb 20, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 20, 2023
@yardenshoham yardenshoham deleted the patch-1 branch February 20, 2023 09:10
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants