Refactor git storage and command

[lunny]

No description provided.

[wxiaoguang]

Why?

[lunny]

To keep the default description, so we can remove most descriptions when invoking git command.

[wxiaoguang]

Then SetDescription will be removed, right?

[lunny]

That still will be kept but in most places, we don't need that function.

[wxiaoguang]

SetDescription still will be kept but in most places, we don't need that function.

Then I still can not get the point why SetDescription and SetExtraDescription should both exist.

[wxiaoguang]

After grepping the calls to SetDescription and SetExtraDescription. If I understand correctly, the SetDescription is mainly for making the description of git command with long arguments to be concise and add repoPath to the description.

But SetDescription and SetExtraDescription really seem similar and may be misused later ....

(just a discussion, no more thoughts from my side)

[wxiaoguang]

Just thought about an interesting idea:

cmd.SetDescription("totally new description: %s, %d", filename, line)
cmd.SetDescription("${cmd}, and extra description: %s, %d", filename, line)

The ${cmd} could be replaced by the command and arguments.

Then only one function is enough. And one command always have one description (no extra). And no need to call Sprintf separately when setting the description.

ps: I know the trick ${cmd} is arguable, so not sure whether it is good enough, just FYI and for fun.

[lunny]

replaced by #25071