Skip to content

Lint error.go #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Lint error.go #213

wants to merge 1 commit into from

Conversation

strk
Copy link
Member

@strk strk commented Nov 22, 2016

This was done semi-programmatically, not really documenting anything

This was done semi-programmatically, not really documenting anything
@codecov-io
Copy link

codecov-io commented Nov 22, 2016

Current coverage is 3.03% (diff: 100%)

Merging #213 into master will not change coverage

@@            master      #213   diff @@
========================================
  Files           33        33          
  Lines         8106      8106          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7840      7840          
  Partials        20        20          

Powered by Codecov. Last update cb16028...8851606

@tboerger
Copy link
Member

This doesn't make sense with real text

@bkcsoft
Copy link
Member

bkcsoft commented Nov 22, 2016

Really? This isn't helping anywhere... it just hides the errors from the build, making it harder to find them when someone actually wants to fix them...

If you intend to actually fix the lint-errors you can ask to get this reopened, but I'm close this for now as invalid

@strk
Copy link
Member Author

strk commented Nov 23, 2016

I thought we wanted to make linting checks automatic ? Getting there earlier would give us automatic docs check for future changes, even if leaving existing code untouched...

@tboerger
Copy link
Member

We want to automate lint checks, but these changes won't be detected anymore, so it's pretty useless

@bkcsoft bkcsoft mentioned this pull request Nov 23, 2016
@strk strk mentioned this pull request Nov 24, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
@delvh delvh added issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea and removed reviewed/invalid labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/not-a-bug The reported issue is the intended behavior or the problem is not inside Gitea
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants