Lint error.go #213
Closed
Lint error.go #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done semi-programmatically, not really documenting anything
Current coverage is 3.03% (diff: 100%)@@ master #213 diff @@
========================================
Files 33 33
Lines 8106 8106
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 246 246
Misses 7840 7840
Partials 20 20
|
|
This doesn't make sense with real text |
|
Really? This isn't helping anywhere... it just hides the errors from the build, making it harder to find them when someone actually wants to fix them... If you intend to actually fix the lint-errors you can ask to get this reopened, but I'm close this for now as invalid |
Closed
|
I thought we wanted to make linting checks automatic ? Getting there earlier would give us automatic docs check for future changes, even if leaving existing code untouched... |
|
We want to automate lint checks, but these changes won't be detected anymore, so it's pretty useless |
Closed
Merged
delvh
added
issue/not-a-bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done semi-programmatically, not really documenting anything