Make Clone in VSCode link get updated correctly (#21225) #21226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
type/bug
skip-changelog
lunny
requested review from
silverwind and
wolfogre
and removed request for
silverwind
lunny
approved these changes
Sep 22, 2022
GiteaBot
added
the
lgtm/need 1
wolfogre
approved these changes
Sep 22, 2022
GiteaBot
added
lgtm/done
silverwind
approved these changes
Sep 22, 2022
|
Any reference to mentioned Golang bug? |
Now here it is: |
|
Thanks, we should definitely remove this script and move this localStorage setting to backend database, then we will no longer need inline scripts and the headaches they bring. |
|
If it's a go bug, why is there no problem with v1.18? |
Because Gitea 1.18 doesn't use string interpolation, there is no lint rule for templates, and the code has been tested carefully. But when it's backported to 1.17-dev, the lint rule in 1.17 forced to use string interpolation, then no one tested it, then bug occurs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #21225, fix for #21128 (also in 1.17.3), close #21224
The indent was incorrect before, so this PR did some formatting work.
Bypass Golang's template bug for JS string interpolation. And since there are JS lint rules for templates, so the string interpolation is also a must.
Compare with ignoring white spaces