Skip to content

Fixes #20625 - Puts wiki header links on the right #20627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Eekle
Copy link
Contributor

@Eekle Eekle commented Aug 2, 2022

Moves header links to the right hand side of the text.

Before:

image

After:

image

Fixes #20625

@lunny lunny added this to the 1.18.0 milestone Aug 2, 2022
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Aug 2, 2022
@silverwind
Copy link
Member

I think we want to keep them on the left and we should instead make more space in the box instead, e.g. make the wiki content box render with same/similar horizontal padding as the markdown content box.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 2, 2022
@Eekle
Copy link
Contributor Author

Eekle commented Aug 2, 2022

I think we want to keep them on the left and we should instead make more space in the box instead, e.g. make the wiki content box render with same/similar horizontal padding as the markdown content box.

Would also work yeah!

I was nervous of approaches that made the render area smaller - it already feels a little cramped with the inclusion of the ToC.

@silverwind
Copy link
Member

Yes, area is a bit smaller then on README for example, but there's no hard requirement on how wide a markdown rendering area has to be, so we should strive to get README and wiki rendering to look and feel similar.

@Eekle
Copy link
Contributor Author

Eekle commented Aug 2, 2022

Fair enough. I was slightly surprised that the README and Wiki don't use a shared markdown component.

@silverwind
Copy link
Member

Fair enough. I was slightly surprised that the README and Wiki don't use a shared markdown component.

That would actually be a very good refactor for later.

@silverwind silverwind added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels Aug 3, 2022
@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022
@lunny lunny modified the milestones: 1.19.0, 1.20.0 Feb 3, 2023
@silverwind
Copy link
Member

#23750 includes a fix that adds more padding while keeping the link on left.

@silverwind silverwind closed this Apr 2, 2023
@GiteaBot GiteaBot removed this from the 1.20.0 milestone Apr 23, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section link icons cut off in Wiki
4 participants