Skip to content

Support hostname:port to pass host matcher's check #19543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

wxiaoguang
Copy link
Contributor

Before: ip:port or hostname:port won't be matched.

Now we split the hostname from the hostname:port string, use the correct hostname to do the match.

@wxiaoguang wxiaoguang added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.16 labels Apr 28, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Apr 28, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2022
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 28, 2022
@wxiaoguang wxiaoguang merged commit a51efb4 into go-gitea:main Apr 28, 2022
@wxiaoguang wxiaoguang deleted the fix-hostmatcher-hostport branch April 28, 2022 17:39
wxiaoguang added a commit that referenced this pull request Apr 28, 2022
Backport #19543 
hostmatcher: split the hostname from the hostname:port string, use the correct hostname to do the match.
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this pull request Apr 28, 2022
…go-gitea#19544)

Backport go-gitea#19543 
hostmatcher: split the hostname from the hostname:port string, use the correct hostname to do the match.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 29, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Support `hostname:port` to pass host matcher's check go-gitea#19543  (go-gitea#19543)
  Add "Allow edits from maintainer" feature (go-gitea#18002)
  Better describe what `/repos/{owner}/{repo}/raw/{filepath}` returns on 200 (go-gitea#19542)
  more context for models  (go-gitea#19511)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
…o-gitea#19543)

hostmatcher: split the hostname from the `hostname:port` string, use the correct hostname to do the match.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants