Skip to content

Don't report signal: killed errors in serviceRPC #18850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2022
Merged

Don't report signal: killed errors in serviceRPC #18850

merged 1 commit into from
Feb 22, 2022

Conversation

zeripath
Copy link
Contributor

Fix #18849

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added type/enhancement An improvement of existing functionality backport/v1.16 labels Feb 21, 2022
@zeripath zeripath added this to the 1.17.0 milestone Feb 21, 2022
@zeripath
Copy link
Contributor Author

Backport should not delay 1.16.2

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 22, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2022
@lunny lunny merged commit 704bdf8 into go-gitea:main Feb 22, 2022
@lunny
Copy link
Member

lunny commented Feb 22, 2022

Please send backport

zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 22, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
5d1aa17 
* giteaofficial/main:
  Don't report signal: killed errors in serviceRPC (go-gitea#18850)
@zeripath zeripath deleted the fix-18849-ignore-signal-killed branch February 23, 2022 19:18
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 23, 2022
@zeripath
Don't report signal: killed errors in serviceRPC (go-gitea#18850)
54a73bf 
Backport go-gitea#18850

Fix go-gitea#18849

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Feb 23, 2022
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 24, 2022
lunny added a commit that referenced this pull request Feb 24, 2022
@zeripath @lunny
Don't report signal: killed errors in serviceRPC (#18850) (#18865)
9d9ccdb 
Backport #18850

Fix #18849

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath
Don't report signal: killed errors in serviceRPC (go-gitea#18850)
f5e28fd 
Fix go-gitea#18849

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@Gusted Gusted Gusted approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

serviceRPC() [E] Fail to serve RPC(upload-pack) on client clone abort
4 participants
@zeripath @lunny @Gusted @GiteaBot