Skip to content

Set default AppVer for main branch #18146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set default AppVer for main branch #18146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import (

var (
// Version holds the current Gitea version
Version = "development"
Version = "1.16.9999+dev-main"
Copy link
Contributor

@Gusted Gusted Jan 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to dismantle this:

1.16
Gitea's version

.9999
Uhm.... minor patch is quite high. Guess this is the indication that it's built from development?

+dev-main
IIRC it should be -dev+main. But I'm not sure about the +main part as that is mostly used for build metadata, or something along those lines. Otherwise this could be used as indication that it's development built and then leave the minor patch alone.

Copy link
Contributor Author

@wxiaoguang wxiaoguang Jan 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.9999: because the main branch is always newer than any released version. So I choose the impossible version number 9999. Even during update check, the Gitea 1.16.9999 in development won't tell developers that "there is a new version 1.16.8 available".

+dev-main: it comes from the current Gitea version format, for exmpale, on try.gitea.io: 1.16.0+dev-782-gde8e3948a. And yes, maybe we do not need the last main, we could use 1.16.9999+dev or 1.16.9999+dev-local instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that sense I think we can use +dev-local.

// Tags holds the build tags used
Tags = ""
// MakeVersion holds the current Make version if built with make
Expand Down