Upgrade vendor "git"

[thibaultmeyer]

Upgrade "git" via the command govendor

[strk]

I've tried merging your PR locally and then issuing govendor update.
The result is more files changed, with vendor/vendor.json diff being:

diff --git a/vendor/vendor.json b/vendor/vendor.json
index 14feb1e..34c0384 100644
--- a/vendor/vendor.json
+++ b/vendor/vendor.json
@@ -3,10 +3,10 @@
        "ignore": "test",
        "package": [
                {
-                       "checksumSHA1": "X4WaxEtgFkM4VHg6TcNk2xkrqCI=",
+                       "checksumSHA1": "wpNJd6wl1MHYKjKiso1rzAcaMA0=",
                        "path": "code.gitea.io/git",
-                       "revision": "0807b517283977be34f0ff5510b21e676fc1527c",
-                       "revisionTime": "2016-11-13T14:20:52Z"
+                       "revision": "8e450d945dc3abda09b064617fdb31084b4e7447",
+                       "revisionTime": "2016-11-12T10:45:46Z"
                },
                {
                        "checksumSHA1": "/uhZZppDeb3Rbp3h8C0ALR3hdrA=",

Can you understand what does that mean ?

[codecov-io]

Current coverage is 3.03% (diff: 100%)

Merging #175 into master will not change coverage

@@            master      #175   diff @@
========================================
  Files           33        33          
  Lines         8096      8096          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7830      7830          
  Partials        20        20          

Powered by Codecov. Last update 56a8cf5...f0efd72

[strk]

FYI: go get works fine with git submodules starting with versione 1.6: golang/go@761ac75

[thibaultmeyer]

@strk, I don't know why your command govendor use a too older commit hash (8e450d945d who is ~30 commits back from last commit on master branch).

[strk]

Maybe my call is wrong, how do you invoke it ? I did govendor update code.gitea.io/git

[thibaultmeyer]

Maybe is me... I have called go vendor fetch code.gitea.io/git

[strk]

Figured, go vendor update code.gitea.io/git took the code from my GOPATH, which was outdated.
Updating my local code and/or using fetch gives me a single change from your PR:

diff --git a/vendor/vendor.json b/vendor/vendor.json
index 14feb1e..59fe8fa 100644
--- a/vendor/vendor.json
+++ b/vendor/vendor.json
@@ -3,7 +3,7 @@
        "ignore": "test",
        "package": [
                {
-                       "checksumSHA1": "X4WaxEtgFkM4VHg6TcNk2xkrqCI=",
+                       "checksumSHA1": "NG9QAxoTz9rFH8054YQ3a9e9hs8=",
                        "path": "code.gitea.io/git",
                        "revision": "0807b517283977be34f0ff5510b21e676fc1527c",
                        "revisionTime": "2016-11-13T14:20:52Z"

Ideas about what that checksum is about ?

[strk]

govendor v1.0.3, go version go1.6.2 linux/amd64

[thibaultmeyer]

D:\Users\thiba\Documents>go version
go version go1.7.3 windows/amd64

D:\Users\thiba\Documents>govendor --version
v1.0.8

[strk]

Question: is there anything particular you need from the new version of the git module ?
(ie: it may be useful to reduce vendor/ changes)

It looks like we're not alone with the checksum issue: https://github.com/kardianos/govendor/issues/233#issuecomment-254037185

[thibaultmeyer]

Yes, to get the newly added function GetCommitsInfoWithCustomConcurrency

[strk]

Could you maybe include the vendor update as part of the PR making use of the new function ?

[strk]

@bkcsoft, @tboerger, @lunny what do you think about setting a policy for vendor/ updating ?

[thibaultmeyer]

if @bkcsoft, @tboerger, @lunny are OK with that, of course I can merge into one PR git module upgrade and new gitea feature.

[lunny]

Yes, we need a policy. Who can draft one?

[tboerger]

We can write a policy for it but for now LGTM

[strk]

Well, given I can confirm this PR does upgrade 'git' module to an existing upstream state, it also LGTM.
Figuring out govendor's checksumSHA1 can wait...