Skip to content

Fix markdown checkbox rendering #17425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Oct 25, 2021

We allow to render empty check list item - [ ], while GitHub doesn't allow.

To make the rendering correct, we need tune the UI (the last PR #17411 uses absolute layout, which makes the empty checkbox item can not be displayed correctly)

- [ ] test checkbox

- [ ] 

- [ ] 

- [x] 


-----



- [ ] test checkbox
- [x] 
- [ ] 
- [x] 

With this PR

image

Without this PR

image

@wxiaoguang wxiaoguang added the topic/ui Change the appearance of the Gitea UI label Oct 25, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Oct 25, 2021
@wxiaoguang wxiaoguang requested a review from noerw October 25, 2021 04:57
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 25, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2021
@6543 6543 merged commit a961666 into go-gitea:main Oct 25, 2021
@wxiaoguang wxiaoguang deleted the fix-markdown-checkbox branch October 25, 2021 07:51
@zeripath zeripath added the backport/done All backports for this PR have been created label Dec 25, 2021
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants