Skip to content

.editorconfig: do not specify line ending #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2016
Merged

.editorconfig: do not specify line ending #171

merged 1 commit into from
Nov 15, 2016

Conversation

andreynering
Copy link
Contributor

That is annoying on Windows, since the editor will change the file if you just open it. Git will checking as LF anyway.

That is annoying on Windows, since the editor will change the file if
you just open it. Git will checking as LF anyway.
@codecov-io
Copy link

Current coverage is 3.03% (diff: 100%)

Merging #171 into master will not change coverage

@@            master      #171   diff @@
========================================
  Files           33        33          
  Lines         8096      8096          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7830      7830          
  Partials        20        20          

Powered by Codecov. Last update 81f227e...a285c07

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 14, 2016
@tboerger
Copy link
Member

I don't understand why windows should change anything if your editor respects this setting?

@thibaultmeyer
Copy link
Contributor

That the point. This PR remove the setting who force Windows to use LF rather than CRLF.

@tboerger
Copy link
Member

I don't have a strong opinion on that, I'm anyway using my Sublime settings. LGTM

@tboerger tboerger added type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 15, 2016
@strk
Copy link
Member

strk commented Nov 15, 2016

@andreynering are you sure git will check in as LF anyway ? Why would it do do ? (I see something in .gitattributes but I'm not sure how that work)

@andreynering
Copy link
Contributor Author

Yes, Git by convention on Windows, checkout as CRLF and check-in as LF.

When you have LF on editorconfig, and you open any file, the editor will convert from CRLF to LF, and git status will think all these files changed.

The right think it's just use the default ending of the OS.

@metalmatze
Copy link
Contributor

LGTM

@metalmatze metalmatze merged commit 7596e41 into go-gitea:master Nov 15, 2016
@andreynering andreynering deleted the gitea/editorconfig-crlf branch November 15, 2016 11:07
@tboerger tboerger removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 15, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants